D17986: Build the Java side with Gradle, as AAR instead of JAR
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Most importantly this allows us to use the AndroidX support library, to properly support a wide range of different Android versions (we link to that for demonstration purposes only atm, it's not actually used yet). This is closer to the Android way of doing things than the previous raw approach, which should be more sustainable. The obvious dirty things this does like copying the build tool into the project or downloading tons of stuff during the build seem to be "normal". For this to be consumable by application, a tiny change to their build.gradle files is needed: https://codereview.qt-project.org/#/c/249179/ REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D17986 AFFECTED FILES CMakeLists.txt cmake/modules/FindGradle.cmake cmake/modules/local.properties.in cmake/modules/settings.gradle.in src/AndroidManifest.xml src/CMakeLists.txt src/KF5Notifications-android-dependencies.xml src/build.gradle To: vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D17986: Build the Java side with Gradle, as AAR instead of JAR
apol added a comment. Maybe put it in an android subdirectory? having it straight in src feels odd. Other than that +1 INLINE COMMENTS > FindGradle.cmake:5 > +# > +# Provides the ability to build Android AAR libraries using Gradle. > +# Sounds like it should be in ECM, no? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D17986 To: vkrause Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns
D17986: Build the Java side with Gradle, as AAR instead of JAR
vkrause updated this revision to Diff 48881. vkrause added a comment. Move Android specifc stuff into a subdir. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17986?vs=48727&id=48881 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17986 AFFECTED FILES CMakeLists.txt cmake/modules/FindGradle.cmake cmake/modules/local.properties.in cmake/modules/settings.gradle.in src/CMakeLists.txt src/KF5Notifications-android-dependencies.xml src/android/AndroidManifest.xml src/android/CMakeLists.txt src/android/build.gradle src/android/org/kde/knotifications/KNotification.java src/android/org/kde/knotifications/NotifyByAndroid.java src/org/kde/knotifications/KNotification.java src/org/kde/knotifications/NotifyByAndroid.java To: vkrause Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns
D17986: Build the Java side with Gradle, as AAR instead of JAR
vkrause added inline comments. INLINE COMMENTS > apol wrote in FindGradle.cmake:5 > Sounds like it should be in ECM, no? Right, that's the obvious final location for this, once it has proven itself as the right approach here. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D17986 To: vkrause Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns
D17986: Build the Java side with Gradle, as AAR instead of JAR
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D17986 To: vkrause, apol Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns
D17986: Build the Java side with Gradle, as AAR instead of JAR
This revision was automatically updated to reflect the committed changes. Closed by commit R289:054b4548ce1e: Build the Java side with Gradle, as AAR instead of JAR (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17986?vs=48881&id=49026#toc REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17986?vs=48881&id=49026 REVISION DETAIL https://phabricator.kde.org/D17986 AFFECTED FILES CMakeLists.txt cmake/modules/FindGradle.cmake cmake/modules/local.properties.in cmake/modules/settings.gradle.in src/CMakeLists.txt src/KF5Notifications-android-dependencies.xml src/android/AndroidManifest.xml src/android/CMakeLists.txt src/android/build.gradle src/android/org/kde/knotifications/KNotification.java src/android/org/kde/knotifications/NotifyByAndroid.java src/org/kde/knotifications/KNotification.java src/org/kde/knotifications/NotifyByAndroid.java To: vkrause, apol Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns
