D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a comment.


  In D18114#498642 , @romangg wrote:
  
  > @jgrulich With D22571  looking 
promising do you want to put the keyboard parts of this diff into a separate 
one? There is still the question about keysyms and key events but we should 
discuss this in the new diff. Maybe we can have both: Keysyms for special keys 
/ combinations like Alt+Tab and text input via text-input protocol?
  
  
  I currently don't have that much time to look into this, but I'm glad we can 
move with this further. Maybe Akademy is a good opportunity to work on this, 
there are also some things which would be nice to improve in screen sharing 
support.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: romangg, graesslin, zzag, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Roman Gilg]

romangg added a comment.


  @jgrulich With D22571  looking promising 
do you want to put the keyboard parts of this diff into a separate one? There 
is still the question about keysyms and key events but we should discuss this 
in the new diff. Maybe we can have both: Keysyms for special keys / 
combinations like Alt+Tab and text input via text-input protocol?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: romangg, graesslin, zzag, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:12b58edd254a: FakeInput: add support for pointer move 
with absolute coordinates (authored by jgrulich).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49133&id=51668

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  Given we have absolute events for other input, this makes sense.
  
  Ship it

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a comment.


  Ping @graesslin?
  
  Martin, can you please look into this?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a comment.


  Hi, can I get please this re-approved? It's now just again about the 
additional mouse support.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Jan Grulich]

jgrulich updated this revision to Diff 49133.
jgrulich added a comment.


  Drop keyboard support from this review

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49087&id=49133

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich retitled this revision from "FakeInput: add support for pointer move 
with absolute coordinates and keyboard key press and release" to "FakeInput: 
add support for pointer move with absolute coordinates".
jgrulich edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Martin Flöser]

graesslin added a comment.


  I'm the author of this interface and I consider it nowadays as a mistake to 
have added it. If I would restart I would do the whole thing differently: input 
events need to be injected through a kernel module in a dedicated input device. 
It would need a user space component which processes can talk to and that would 
need to be secured though e.g. polkit. Thus we could properly authenticate. 
This protocol does not support it and KWin does not even try to authenticate. 
Overall from security perspective this is a mess.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Martin Flöser]

graesslin added a comment.


  I don't want to have key press/release in it. It has a reason that I didn't 
add key press/release from the start. The problem is the mismatch of key events 
and keysyms. Especially the kdeconnect use case for which this interface was 
developed has this problem. Android composes text, not key codes. Thus it would 
not be possible to inject key events.
  
  Also from a security perspective I'm strictly against adding fake key events. 
That's one of the largest security problems on X11. I rather have no remote 
support than a gaping security hole.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Jan Grulich]

jgrulich updated this revision to Diff 49087.
jgrulich added a comment.


  Fix documentation

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49082&id=49087

BRANCH
  fake-input-keyboard-key

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Jan Grulich]

jgrulich added a comment.


  I didn't intent to push this together, but when creating a branch from master 
which already had first round of changes caused my second part of changes to be 
pushed here. I hope you don't mind that. I'm doing this in a hurry hoping to 
get exception from David Faure to include this with KDE Frameworks 5.54. I 
thought the tagging is this saturday and tarballs are made after that, but I 
was wrong. I would really like to push the remote desktop support into Plasma 
5.15, I have almost complete support in xdg-desktop-portal-kde and krfb.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Jan Grulich]

jgrulich retitled this revision from "FakeInput: add support for pointer move 
with absolute coordinates" to "FakeInput: add support for pointer move with 
absolute coordinates and keyboard key press and release".
jgrulich edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49082.
jgrulich added a comment.


  Add support for keyboard key press and release

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49081&id=49082

BRANCH
  fake-input-keyboard-key

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49081.
jgrulich added a comment.


  Bump fake interface version

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49071&id=49081

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag accepted this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49071.
jgrulich added a comment.


  Coding style

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49070&id=49071

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag accepted this revision.
zzag added inline comments.

INLINE COMMENTS

> fakeinput.cpp:106
> +Q_ASSERT(d->manager.isValid());
> +if (wl_proxy_get_version(d->manager) < 
> ORG_KDE_KWIN_FAKE_INPUT_POINTER_MOTION_ABSOLUTE_SINCE_VERSION)
> +return;

Use curly braces even when the body of a conditional statement contains only 
one line.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49070.
jgrulich added a comment.


  Fix review comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49069&id=49070

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> fake-input.xml:86
>
> +  
> +  

since="3"

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49069.
jgrulich added a comment.


  Adress review comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49066&id=49069

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> fakeinput.cpp:106
> +Q_ASSERT(d->manager.isValid());
> +org_kde_kwin_fake_input_pointer_motion_absolute(d->manager, 
> wl_fixed_from_double(pos.x()), wl_fixed_from_double(pos.y()));
> +}

if (wl_proxy_get_version(d->manager) < 
ORG_KDE_SOMETHING_SOMETHING_FAKE_INPUT_VERSION) {
 return;
}

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag accepted this revision.
zzag added a comment.


  Please wait for @davidedmundson and @graesslin. :-)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich marked 2 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49066.
jgrulich added a comment.


  Add information when new methods were introduced and bump version of 
FakeInput in registry

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49064&id=49066

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> fakeinput_interface.cpp:164
> +
> +
>  void FakeInputInterface::Private::axisCallback(wl_client *client, 
> wl_resource *resource, uint32_t axis, wl_fixed_t value)

Please delete one extra empty line.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag added a comment.


  maxVersion in src/client/registry.cpp should be updated as well.

INLINE COMMENTS

> fakeinput.h:138
> + * Request an absolute pointer motion to @p pos position.
> + **/
> +void requestPointerMoveAbsolute(const QPointF &pos);

Missing `@since`.

> fakeinput_interface.h:118
> + * Request an absolute pointer motion to @p pos.
> + **/
> +void pointerMotionAbsoluteRequested(const QPointF &pos);

Missing `@since`.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49064.
jgrulich added a comment.


  Revert unwanted changes in CMakeLists

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49046&id=49064

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich marked 4 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49046.
jgrulich added a comment.


  Use QPointF instead of QSizeF and bump interface version

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49028&id=49046

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  CMakeLists.txt
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fake-input.xml:44
>
> +  
> +  

New requests can only be added at end. Since is missing.

> fakeinput_interface.cpp:85
>  pointerMotionCallback,
> +pointerMotionAbsoluteCallback,
>  buttonCallback,

Must be last, new requests only at end.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> fakeinput.h:139
> + **/
> +void requestPointerMoveAbsolute(const QSizeF &pos);
>  /**

Wouldn't QPointF be a better choice?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> fake-input.xml:19
>]]>
>
>

Version of the interface has to be bumped.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a dependent revision: D18115: Add support for fake pointer move 
with absolute coordinates.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a reviewer: davidedmundson.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  For remote desktop support, we need to move with the pointer using absolute 
position.

TEST PLAN
  I tested this with xdg-desktop-portal-kde and krfb and it worked.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns