D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release
jgrulich updated this revision to Diff 49133. jgrulich added a comment. Drop keyboard support from this review REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49087=49133 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES autotests/client/test_fake_input.cpp src/client/fakeinput.cpp src/client/fakeinput.h src/client/protocols/fake-input.xml src/client/registry.cpp src/server/fakeinput_interface.cpp src/server/fakeinput_interface.h To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release
graesslin added a comment. I'm the author of this interface and I consider it nowadays as a mistake to have added it. If I would restart I would do the whole thing differently: input events need to be injected through a kernel module in a dedicated input device. It would need a user space component which processes can talk to and that would need to be secured though e.g. polkit. Thus we could properly authenticate. This protocol does not support it and KWin does not even try to authenticate. Overall from security perspective this is a mess. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release
graesslin added a comment. I don't want to have key press/release in it. It has a reason that I didn't add key press/release from the start. The problem is the mismatch of key events and keysyms. Especially the kdeconnect use case for which this interface was developed has this problem. Android composes text, not key codes. Thus it would not be possible to inject key events. Also from a security perspective I'm strictly against adding fake key events. That's one of the largest security problems on X11. I rather have no remote support than a gaping security hole. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release
jgrulich updated this revision to Diff 49087. jgrulich added a comment. Fix documentation REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49082=49087 BRANCH fake-input-keyboard-key REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES autotests/client/test_fake_input.cpp src/client/fakeinput.cpp src/client/fakeinput.h src/client/protocols/fake-input.xml src/client/registry.cpp src/server/fakeinput_interface.cpp src/server/fakeinput_interface.h To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release
jgrulich added a comment. I didn't intent to push this together, but when creating a branch from master which already had first round of changes caused my second part of changes to be pushed here. I hope you don't mind that. I'm doing this in a hurry hoping to get exception from David Faure to include this with KDE Frameworks 5.54. I thought the tagging is this saturday and tarballs are made after that, but I was wrong. I would really like to push the remote desktop support into Plasma 5.15, I have almost complete support in xdg-desktop-portal-kde and krfb. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release
jgrulich retitled this revision from "FakeInput: add support for pointer move with absolute coordinates" to "FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release". jgrulich edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
