D18116: Don't show document load trouble twice

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Just to be sure:
  
  We can apply D18117  and don't need to 
change here anything or?

REVISION DETAIL
  https://phabricator.kde.org/D18116

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18116: Don't show document load trouble twice

[Christoph Cullmann]

cullmann added a comment.


  I would not change that here, I would just ignore it in the application, as 
said in the other diff.

REVISION DETAIL
  https://phabricator.kde.org/D18116

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18116: Don't show document load trouble twice

[Dominik Haumann]

dhaumann added a comment.


  Just for info: If openingErrorMessage is indeed not set anymore, this is a 
behavior change, since KTextEditor::Document::openingErrorMessage() is public 
API. Looking at lxr.kde.org, it seems this is not used (but ->openingError() is 
used, see 
https://lxr.kde.org/source/kde/applications/kate/addons/filetree/katefiletreemodel.cpp#0554).

REVISION DETAIL
  https://phabricator.kde.org/D18116

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18116: Don't show document load trouble twice

[loh tar]

loh.tar updated this revision to Diff 50027.
loh.tar added a comment.


  - Don't set m_openingErrorMessage in KateBuffer::openFile
  - m_openingErrorMessage is now nowhere set

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18116?vs=49031=50027

REVISION DETAIL
  https://phabricator.kde.org/D18116

AFFECTED FILES
  src/document/katebuffer.cpp
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18116: Don't show document load trouble twice

[loh tar]

loh.tar added a comment.


  I have it only poor tested with our big S file, so no test was made with 
other trouble causing stuff.
  This need a patch in Kate, will try to link that
  
  KateBuffer::openFile
  
  - There is no distingues from
1. "create new file by command line" and
2. "restore files of session"
  - When..
1. is the error wrong
2. makes to me "new file" not much sense
  
  Is there a way to check wat is going on, 1) or 2) ? Guess, yes, and you can 
point me

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18116

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18116: Don't show document load trouble twice

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Since there are fancy "in view" messages which show all loading trouble
  are the still existent popup dialogs redundant, hence removed

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18116

AFFECTED FILES
  src/document/katebuffer.cpp
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann