D18148: Use HTTPS, if available, in links visible to users
This revision was automatically updated to reflect the committed changes. Closed by commit R39:b64681408d84: Use HTTPS, if available, in links visible to users (authored by gszymaszek). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18148?vs=49138=49140 REVISION DETAIL https://phabricator.kde.org/D18148 AFFECTED FILES src/document/katedocument.cpp src/utils/kateglobal.cpp To: gszymaszek, #ktexteditor, dhaumann Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D18148: Use HTTPS, if available, in links visible to users
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH https-in-end-user-links (branched from master) REVISION DETAIL https://phabricator.kde.org/D18148 To: gszymaszek, #ktexteditor, dhaumann Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D18148: Use HTTPS, if available, in links visible to users
gszymaszek marked 2 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18148 To: gszymaszek, #ktexteditor Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D18148: Use HTTPS, if available, in links visible to users
gszymaszek updated this revision to Diff 49138. gszymaszek added a comment. Fixed two links to docs.kde.org REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18148?vs=49135=49138 BRANCH https-in-end-user-links (branched from master) REVISION DETAIL https://phabricator.kde.org/D18148 AFFECTED FILES src/document/katedocument.cpp src/utils/kateglobal.cpp To: gszymaszek, #ktexteditor Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D18148: Use HTTPS, if available, in links visible to users
lueck added inline comments. INLINE COMMENTS > katedocument.cpp:4592 > "Please replace with > 'remove-trailing-spaces modified;', see " > - > "http://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;); > + > "https://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;); > m_config->setRemoveSpaces(state ? 1 : 0); dead link: The requested URL /stable5/en/applications/kate/config-variables.html was not found on this server. This link works: https://docs.kde.org/stable5/en/applications/katepart/config-variables.html#variable-remove-trailing-spaces > katedocument.cpp:4597 > "Please replace with > 'remove-trailing-spaces all;', see " > - > "http://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;); > + > "https://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;); > m_config->setRemoveSpaces(state ? 2 : 0); dead link, see above REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18148 To: gszymaszek, #ktexteditor Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D18148: Use HTTPS, if available, in links visible to users
gszymaszek retitled this revision from "Use HTTPS, if available, in links visible by users" to "Use HTTPS, if available, in links visible to users". gszymaszek added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18148 To: gszymaszek, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D18148: Use HTTPS, if available, in links visible by users
gszymaszek created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. gszymaszek requested review of this revision. REPOSITORY R39 KTextEditor BRANCH https-in-end-user-links (branched from master) REVISION DETAIL https://phabricator.kde.org/D18148 AFFECTED FILES src/document/katedocument.cpp src/utils/kateglobal.cpp To: gszymaszek Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann