D18390: Build without D-Bus on Android

2019-01-25 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:d5e76df55828: Build without D-Bus on Android (authored by 
vkrause).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18390?vs=49895=50267

REVISION DETAIL
  https://phabricator.kde.org/D18390

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kbookmarkmanager.cpp
  src/kbookmarkmanager.h

To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18390: Build without D-Bus on Android

2019-01-20 Thread Volker Krause 
vkrause added a comment.


  In D18390#396771 , @dhaumann wrote:
  
  > You likely get a warning about an unused variable now in 
KBookmarkManager::init(const QString ), since the function is empty.
  
  
  Yep (and same for the other frameworks). I don't expect this to be the final 
state though, it's a first step to get things building without the D-Bus stub 
on Android at all, and get an overview of the gaps. Some cases will need a 
proper Android implementation, some might end up being mere porting aids that 
make no sense on Android.

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18390

To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18390: Build without D-Bus on Android

2019-01-20 Thread Dominik Haumann 
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me.
  
  You likely get a warning about an unused variable now in 
KBookmarkManager::init(const QString ), since the function is empty.

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18390

To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18390: Build without D-Bus on Android

2019-01-19 Thread Volker Krause 
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18390

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kbookmarkmanager.cpp
  src/kbookmarkmanager.h

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns