D18439: Add proper edit-delete-shred icons

2019-01-21 Thread TrickyRicky 
trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  proper-shred-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18439

AFFECTED FILES
  icons-dark/actions/16/edit-delete-shred.svg
  icons-dark/actions/22/edit-delete-shred.svg
  icons-dark/actions/24/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete.svg
  icons/actions/16/edit-delete-shred.svg
  icons/actions/22/edit-delete-shred.svg
  icons/actions/24/edit-delete-shred.svg
  icons/actions/32/edit-delete-shred.svg
  icons/actions/32/edit-delete.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18439: Add proper edit-delete-shred icons

2019-01-21 Thread TrickyRicky 
trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18439: Add proper edit-delete-shred icons

2019-01-21 Thread Nathaniel Graham 
ngraham added a comment.


  Symlink shenanigans make the patch not apply due to that Phab bug. :(
  
Created and checked out branch arcpatch-D18439.
Checking patch icons/actions/32/edit-delete.svg...
Checking patch icons/actions/32/edit-delete-shred.svg...
Checking patch dev/null => icons/actions/24/edit-delete-shred.svg...
error: dev/null: does not exist in index
Checking patch dev/null => icons/actions/22/edit-delete-shred.svg...
error: dev/null: does not exist in index
Checking patch dev/null => icons/actions/16/edit-delete-shred.svg...
error: dev/null: does not exist in index
Checking patch icons-dark/actions/32/edit-delete.svg...
Checking patch icons-dark/actions/32/edit-delete-shred.svg...
Checking patch dev/null => icons-dark/actions/24/edit-delete-shred.svg...
error: dev/null: does not exist in index
Checking patch dev/null => icons-dark/actions/22/edit-delete-shred.svg...
error: dev/null: does not exist in index
Checking patch dev/null => icons-dark/actions/16/edit-delete-shred.svg...
error: dev/null: does not exist in index
Applied patch icons/actions/32/edit-delete.svg cleanly.
Applied patch icons/actions/32/edit-delete-shred.svg cleanly.
Applied patch icons-dark/actions/32/edit-delete.svg cleanly.
Applied patch icons-dark/actions/32/edit-delete-shred.svg cleanly.
  
  If you give me a list of symlink changes that need to be done, I can make 
them manually and then you can rebase this patch to only change icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-21 Thread Nathaniel Graham 
ngraham added a comment.


  Also, visually speaking, I think that the checkerboard grid on the bottom is 
too fine. Making it a bit more coarse might improve things. Also have you 
experimented with using vertical lines instead of a checkerboard? Or maybe a 
checkerboard of vertical lines rather than squares? What's what my shredder 
does.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-21 Thread TrickyRicky 
trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  I will experiment with some more pattern for the shredded part.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-22 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 50067.
trickyricky26 added a comment.


  - Use different, more recognizable pattern for the shredded part

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18439?vs=50026&id=50067

BRANCH
  proper-shred-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18439

AFFECTED FILES
  icons-dark/actions/16/edit-delete-shred.svg
  icons-dark/actions/22/edit-delete-shred.svg
  icons-dark/actions/24/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete.svg
  icons/actions/16/edit-delete-shred.svg
  icons/actions/22/edit-delete-shred.svg
  icons/actions/24/edit-delete-shred.svg
  icons/actions/32/edit-delete-shred.svg
  icons/actions/32/edit-delete.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-22 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-22 Thread Nathaniel Graham 
ngraham added a comment.


  Better, though for the 32px version, the shreds feel too skinny. Maybe making 
them 2px wide might improve the look?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-23 Thread TrickyRicky 
trickyricky26 added a comment.


  Do you think these are better?
  F6563857: edit-delete-shred-alt-pattern-32.svg.png 

  This has smaller gaps, which are still large enough imo.
  F6563859: edit-delete-shred-alt-pattern2-32.svg.png 

  This has bigger gaps and isn't quite as pretty.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-23 Thread Nathaniel Graham 
ngraham added a comment.


  In D18439#398526 , @trickyricky26 
wrote:
  
  > Do you think these are better?
  >  F6563857: edit-delete-shred-alt-pattern-32.svg.png 

  
  
  I like this one!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-23 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 50116.
trickyricky26 added a comment.


  - Use a pattern with wider paper strips in the 32px version

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18439?vs=50067&id=50116

BRANCH
  proper-shred-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18439

AFFECTED FILES
  icons-dark/actions/16/edit-delete-shred.svg
  icons-dark/actions/22/edit-delete-shred.svg
  icons-dark/actions/24/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete.svg
  icons/actions/16/edit-delete-shred.svg
  icons/actions/22/edit-delete-shred.svg
  icons/actions/24/edit-delete-shred.svg
  icons/actions/32/edit-delete-shred.svg
  icons/actions/32/edit-delete.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-23 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-23 Thread Noah Davis 
ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I've checked the files and they all look good to me.

REPOSITORY
  R266 Breeze Icons

BRANCH
  proper-shred-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-23 Thread Nathaniel Graham 
ngraham accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  proper-shred-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg, ndavis, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-23 Thread Nathaniel Graham 
ngraham added a comment.


  Still can't actually apply the patch to land it using Phab. Can you remove 
the symlink-related changes from this patch and then provide a list of them so 
I can do them manually?

REPOSITORY
  R266 Breeze Icons

BRANCH
  proper-shred-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18439

To: trickyricky26, #vdg, ndavis, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-26 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 50341.
trickyricky26 added a comment.


  Hopefully finally rebase on master, please?

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18439?vs=50116&id=50341

BRANCH
  arcpatch-D18439

REVISION DETAIL
  https://phabricator.kde.org/D18439

AFFECTED FILES
  icons-dark/actions/16/edit-delete-shred.svg
  icons-dark/actions/22/edit-delete-shred.svg
  icons-dark/actions/24/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete.svg
  icons/actions/16/edit-delete-shred.svg
  icons/actions/22/edit-delete-shred.svg
  icons/actions/24/edit-delete-shred.svg
  icons/actions/32/edit-delete-shred.svg
  icons/actions/32/edit-delete.svg

To: trickyricky26, #vdg, ndavis, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D18439: Add proper edit-delete-shred icons

2019-01-26 Thread Noah Davis 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:a8d82b00afdb: Add proper edit-delete-shred icons 
(authored by trickyricky26, committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18439?vs=50341&id=50348

REVISION DETAIL
  https://phabricator.kde.org/D18439

AFFECTED FILES
  icons-dark/actions/16/edit-delete-shred.svg
  icons-dark/actions/22/edit-delete-shred.svg
  icons-dark/actions/24/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete-shred.svg
  icons-dark/actions/32/edit-delete.svg
  icons/actions/16/edit-delete-shred.svg
  icons/actions/22/edit-delete-shred.svg
  icons/actions/24/edit-delete-shred.svg
  icons/actions/32/edit-delete-shred.svg
  icons/actions/32/edit-delete.svg

To: trickyricky26, #vdg, ndavis, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns