D18610: Introduce KF5AuthCore

[Alexander Volkov]

volkov added a comment.


  Fix for .pri: D25397 

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: volkov, rikmills, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Alexander Volkov]

volkov added a comment.


  What about qmake?
  I came across the following error:
  
g++ -Wl,-z,relro -o ... /usr/lib/x86_64-linux-gnu/libQt5Gui.so 
/usr/lib/x86_64-linux-gnu/libKF5Auth.so 
/usr/lib/x86_64-linux-gnu/libKF5CoreAddons.so 
/usr/lib/x86_64-linux-gnu/libQt5Core.so /usr/lib/x86_64-linux-gnu/libGL.so 
-lpthread   
/usr/bin/ld: ...: undefined reference to symbol '_ZN5KAuth11ActionReplyD1Ev'
/usr/bin/ld: //usr/lib/x86_64-linux-gnu/libKF5AuthCore.so.5: error adding 
symbols: DSO missing from command line

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: volkov, rikmills, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Albert Astals Cid]

aacid added a comment.


  It's only BIC for windows IIRC, the rest of the world is fine, KF5Auth pulls 
KF5AuthCore so all the symbols are still tehre.
  
  i don't really think we care about abi in windows for KAuth which AFAICS 
doesn't even have a windows backend.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: rikmills, sitter, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Rik Mills]

rikmills added subscribers: sitter, rikmills.
rikmills added a comment.


  Is this not breaking ABI? even if just moving to another lib?
  
  @sitter FYI I get https://paste.ubuntu.com/p/NHsbqg7DbN/

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: rikmills, sitter, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R283 KAuth

BRANCH
  arcpatch-D18610

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Albert Astals Cid]

aacid updated this revision to Diff 50622.
aacid added a comment.


  Only have one debug category for now

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18610?vs=50563=50622

BRANCH
  arcpatch-D18610

REVISION DETAIL
  https://phabricator.kde.org/D18610

AFFECTED FILES
  src/CMakeLists.txt

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kauthobjectdecorator.cpp:69
>  
> -qCWarning(KAUTH) << Q_FUNC_INFO << "We're not decorating an action or a 
> button";
> +qCWarning(KAUTHWIDGET) << Q_FUNC_INFO << "We're not decorating an action 
> or a button";
>  }

It could make sense to leave this as KAUTH and have the rest as KAUTHCORE? this 
way they all have the same name as the library.

Or we just leave them all as KAUTH, like the framework.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Albert Astals Cid]

aacid updated this revision to Diff 50563.
aacid retitled this revision from "Introduce KF5AuthNoWidgets" to "Introduce 
KF5AuthCore".
aacid edited the summary of this revision.
aacid added a comment.


  Much better name as suggested by Aleix

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18610?vs=50536=50563

BRANCH
  arcpatch-D18610_1

REVISION DETAIL
  https://phabricator.kde.org/D18610

AFFECTED FILES
  src/CMakeLists.txt
  src/kauthobjectdecorator.cpp

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns