D18622: Remove monochrome preferences-system symlinks

2019-01-30 Thread Noah Davis
ndavis abandoned this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18622

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D18622: Remove monochrome preferences-system symlinks

2019-01-30 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Instead of landing this patch, please revert the offending commit itself 
using `git revert 14bbb8f64ba2d4aa29b3a3b3b186fca36979fbef`, add the 
explanation message from here into the commit message for the reversion commit, 
and push directly. Then you can abandon this revision.
  
  That will make the git history of this issue more obvious for the future.

REPOSITORY
  R266 Breeze Icons

BRANCH
  remove-monochrome-preferences-system (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18622

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns


D18622: Remove monochrome preferences-system symlinks

2019-01-30 Thread Noah Davis
ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18622

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18622: Remove monochrome preferences-system symlinks

2019-01-30 Thread Noah Davis
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Remove some monochrome preferences-system symlinks that were added for 
compatibility with 3rd party applications. For some reason, `preferences-system 
was only showing up as a monochrome icon with the Breeze icon theme (light 
version, not Breeze Dark). While I don't think the source of the problem was 
these symlinks, I am removing them to prevent the problem from affecting users 
in KF5.55.

REPOSITORY
  R266 Breeze Icons

BRANCH
  remove-monochrome-preferences-system (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18622

AFFECTED FILES
  icons-dark/actions/16/preferences-system.svg
  icons-dark/actions/22/preferences-system.svg
  icons-dark/actions/24/preferences-system.svg
  icons/actions/16/preferences-system.svg
  icons/actions/22/preferences-system.svg
  icons/actions/24/preferences-system.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns