D18662: Add and rename some YaST icon symlinks because of Qt bugs

[Stasiek Michalski]

hellcp added a comment.


  It's not really a workaround, all of those icons are valid when  it comes to 
YaST, however previous batch of YaST icons into Breeze was build on idea that 
icon `xyz-abc.svg` will fallback to `xyz.svg` inside the same icon theme. In 
QIcon::fromTheme that is the case IF icon `xyz-abc.svg` does not exist in 
hicolor or any other fallback theme.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks because of Qt bugs

[Noah Davis]

ndavis added a subscriber: hellcp.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks because of Qt bugs

[Fabian Vogt]

fvogt added a comment.


  In D18662#403612 , @ndavis wrote:
  
  > @fvogt LCP said a Qt bug was the reason that the icons weren't working 
correctly and that you would know more about it. I never got around to asking 
you though. Do you know which bug it is?
  
  
  I don't remember any bug with fallback names. The only one that is vaguely 
related is https://bugs.kde.org/show_bug.cgi?id=402172, but I doubt it's that 
one.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks because of Qt bugs

[Noah Davis]

ndavis added a subscriber: fvogt.
ndavis added a comment.


  @fvogt LCP said a Qt bug was the reason that the icons weren't working 
correctly and that you would know more about it. I never got around to asking 
you though. Do you know which bug it is?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks because of Qt bugs

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks because of Qt bugs

[Nathaniel Graham]

ngraham added a comment.


  General policy surrounding workarounds that are committed to the repo is that 
you need to know and mention the specific bug(s) you're working around.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks because of Qt bugs

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The icons should have worked as they were because they have the correct 
fallback names. However, there were some Qt bugs that kept the fallback icons 
from working in some cases. I have added additional symlinks and renamed some 
symlinks so that they work correctly with the bugs.

REPOSITORY
  R266 Breeze Icons

BRANCH
  more-yast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18662

AFFECTED FILES
  icons-dark/apps/48/yast-control-center.svg
  icons-dark/preferences/32/yast-addon-extension.svg
  icons-dark/preferences/32/yast-hardware-group.svg
  icons-dark/preferences/32/yast-hardware.svg
  icons-dark/preferences/32/yast-ldap-kerberos.svg
  icons-dark/preferences/32/yast-ldap.svg
  icons-dark/preferences/32/yast-misc-group.svg
  icons-dark/preferences/32/yast-misc.svg
  icons-dark/preferences/32/yast-network-group.svg
  icons-dark/preferences/32/yast-network.svg
  icons-dark/preferences/32/yast-security-group.svg
  icons-dark/preferences/32/yast-software-group.svg
  icons-dark/preferences/32/yast-software.svg
  icons-dark/preferences/32/yast-support-group.svg
  icons-dark/preferences/32/yast-system-group.svg
  icons-dark/preferences/32/yast-system.svg
  icons-dark/preferences/32/yast-update-online-configuration.svg
  icons-dark/preferences/32/yast-update-online.svg
  icons-dark/preferences/32/yast-vm-group.svg
  icons-dark/preferences/32/yast-vm.svg
  icons/apps/48/yast-control-center.svg
  icons/preferences/32/yast-addon-extension.svg
  icons/preferences/32/yast-hardware-group.svg
  icons/preferences/32/yast-hardware.svg
  icons/preferences/32/yast-ldap-kerberos.svg
  icons/preferences/32/yast-ldap.svg
  icons/preferences/32/yast-misc-group.svg
  icons/preferences/32/yast-misc.svg
  icons/preferences/32/yast-network-group.svg
  icons/preferences/32/yast-network.svg
  icons/preferences/32/yast-security-group.svg
  icons/preferences/32/yast-software-group.svg
  icons/preferences/32/yast-software.svg
  icons/preferences/32/yast-support-group.svg
  icons/preferences/32/yast-system-group.svg
  icons/preferences/32/yast-system.svg
  icons/preferences/32/yast-update-online-configuration.svg
  icons/preferences/32/yast-update-online.svg
  icons/preferences/32/yast-vm-group.svg
  icons/preferences/32/yast-vm.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns