D18673: Add symlinks for flatpak

[Nibaldo González]

nibags added a comment.


  In D19324  the icons for `code` and 
`code-oss` were added, which also need symbolic links for Flatpak 
(`com.visualstudio.code` & `com.visualstudio.code.oss`)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18673

To: GeeXT, #frameworks, #vdg, ngraham
Cc: ngraham, nibags, kde-frameworks-devel, michaelh, bruns

D18673: Add symlinks for flatpak

[Nathaniel Graham]

ngraham added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18673

To: GeeXT, #frameworks, #vdg
Cc: nibags, kde-frameworks-devel, michaelh, ngraham, bruns

D18673: Add symlinks for flatpak

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I like the functionality, though I'm not thrilled about having to change 
these symlinks around as apps change their appstream IDs, and constabtly add 
new ones as different packagers replace the existing AppStream IDs with their 
own (ugh).  Then again that's already the world we live in and I guess we've 
signed ourselves up for this mess by supporting icons for 3rd-party apps anyway.
  
  This currently causes the `scalable` test to fail, so at a minimum that needs 
to be fixed before this patch can land:
  
FAIL!  : ScalableTest::test_scalable(icons:Applications) The following 
icons are not available in a scalable directory:
  com.github.bajoja.indicator-kdeconnect
   Loc: [/home/dev/kde/src/breeze-icons/autotests/scalabletest.cpp(262)]
FAIL!  : ScalableTest::test_scalable(icons-dark:Applications) The following 
icons are not available in a scalable directory:
  com.github.bajoja.indicator-kdeconnect
  
  Remove the 16px `com.github.bajoja.indicator-kdeconnect` icon symlink, I 
guess.
  
  Looks like @nibags found another one that could be added, too

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18673

To: GeeXT, #frameworks, #vdg, ngraham
Cc: ngraham, nibags, kde-frameworks-devel, michaelh, bruns

D18673: Add symlinks for flatpak

[Nibaldo González]

nibags added a comment.


  +1
  Also missing the symlink for JDownloader (org.jdownloader.JDownloader.svg): 
https://flathub.org/apps/details/org.jdownloader.JDownloader
  
  I don't know if it's also necessary to add symlinks for AppImage apps: 
https://appimage.github.io/apps/
  For example: hotspot.svg -> appimagekit-hotspot.svg

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18673

To: GeeXT, #frameworks
Cc: nibags, kde-frameworks-devel, michaelh, ngraham, bruns

D18673: Add symlinks for flatpak

[Denis Karpovskii]

GeeXT added a reviewer: Frameworks.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18673

To: GeeXT, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18673: Add symlinks for flatpak

[Denis Karpovskii]

GeeXT created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GeeXT requested review of this revision.

REVISION SUMMARY
  This patch creates symlinks (for every application I've
  found on Flathub and for which Breeze icon theme has an icon) to let
  flatpak-provided .desktop files point to breeze-provided icons.
  
  Flatpak-exported .desktop files use different icon names
  (e. g. org.kde.okular instead of just okular) and because of that
  flatpak-provided .desktop files show in menus and panels with their
  default icons instead of breeze-provided icons even when Breeze icon
  theme is used.

TEST PLAN
  This can be tested by applying the patch and installing the icon
  theme into ~/.local/share/icons. Reboot/relogin may be necessary.
  Then to see the changes you can install org.gimp.GIMP from flathub.
  Without the patch GIMP uses its default icon in application
  menus/panels/docks/etc. With the patch it will use the
  breeze-provided icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  flatpak-symlinks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18673

AFFECTED FILES
  icons-dark/apps/16/com.github.bajoja.indicator-kdeconnect.svg
  icons-dark/apps/22/com.github.bajoja.indicator-kdeconnect.svg
  icons-dark/apps/22/org.kde.elisa.svg
  icons-dark/apps/22/org.videolan.VLC.svg
  icons-dark/apps/32/org.videolan.VLC.svg
  icons-dark/apps/48/com.elsevier.MendeleyDesktop.svg
  icons-dark/apps/48/com.google.AndroidStudio.svg
  icons-dark/apps/48/com.sublimetext.three.svg
  icons-dark/apps/48/com.syntevo.SmartGit.svg
  icons-dark/apps/48/com.valvesoftware.Steam.svg
  icons-dark/apps/48/com.viber.Viber.svg
  icons-dark/apps/48/cx.ring.Ring.svg
  icons-dark/apps/48/fr.free.Homebank.svg
  icons-dark/apps/48/fr.handbrake.ghb.svg
  icons-dark/apps/48/io.atom.Atom.svg
  icons-dark/apps/48/io.brackets.Brackets.svg
  icons-dark/apps/48/io.github.Fontforge.svg
  icons-dark/apps/48/net.scribus.Scribus.svg
  icons-dark/apps/48/nl.openoffice.bluefish.svg
  icons-dark/apps/48/org.audacityteam.Audacity.svg
  icons-dark/apps/48/org.blender.Blender.svg
  icons-dark/apps/48/org.clementine_player.Clementine.svg
  icons-dark/apps/48/org.codeblocks.codeblocks.svg
  icons-dark/apps/48/org.darktable.Darktable.svg
  icons-dark/apps/48/org.filezillaproject.Filezilla.svg
  icons-dark/apps/48/org.gimp.GIMP.svg
  icons-dark/apps/48/org.gnu.emacs.svg
  icons-dark/apps/48/org.inkscape.Inkscape.svg
  icons-dark/apps/48/org.kde.elisa.svg
  icons-dark/apps/48/org.kde.kapman.svg
  icons-dark/apps/48/org.kde.katomic.svg
  icons-dark/apps/48/org.kde.kblocks.svg
  icons-dark/apps/48/org.kde.kdenlive.svg
  icons-dark/apps/48/org.kde.kdiamond.svg
  icons-dark/apps/48/org.kde.kjumpingcube.svg
  icons-dark/apps/48/org.kde.klines.svg
  icons-dark/apps/48/org.kde.kolourpaint.svg
  icons-dark/apps/48/org.kde.kontact.svg
  icons-dark/apps/48/org.kde.okular.svg
  icons-dark/apps/48/org.kde.skrooge.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-base.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-calc.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-draw.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-impress.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-main.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-math.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-startcenter.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-writer.svg
  icons-dark/apps/48/org.octave.Octave.svg
  icons-dark/apps/48/org.qbittorrent.qBittorrent.svg
  icons-dark/apps/48/org.qownnotes.QOwnNotes.svg
  icons-dark/apps/48/org.quassel_irc.QuasselClient.svg
  icons-dark/apps/48/org.synfig.SynfigStudio.svg
  icons-dark/apps/48/org.telegram.desktop.svg
  icons-dark/apps/48/org.tordini.flavio.Minitube.svg
  icons-dark/apps/48/org.videolan.VLC.svg
  icons/apps/16/com.github.bajoja.indicator-kdeconnect.svg
  icons/apps/22/com.github.bajoja.indicator-kdeconnect.svg
  icons/apps/22/org.kde.elisa.svg
  icons/apps/22/org.videolan.VLC.svg
  icons/apps/32/org.videolan.VLC.svg
  icons/apps/48/com.elsevier.MendeleyDesktop.svg
  icons/apps/48/com.google.AndroidStudio.svg
  icons/apps/48/com.sublimetext.three.svg
  icons/apps/48/com.syntevo.SmartGit.svg
  icons/apps/48/com.valvesoftware.Steam.svg
  icons/apps/48/com.viber.Viber.svg
  icons/apps/48/cx.ring.Ring.svg
  icons/apps/48/fr.free.Homebank.svg
  icons/apps/48/fr.handbrake.ghb.svg
  icons/apps/48/io.atom.Atom.svg
  icons/apps/48/io.brackets.Brackets.svg
  icons/apps/48/io.github.Fontforge.svg
  icons/apps/48/net.scribus.Scribus.svg
  icons/apps/48/nl.openoffice.bluefish.svg
  icons/apps/48/org.audacityteam.Audacity.svg
  icons/apps/48/org.blender.Blender.svg
  icons/apps/48/org.clementine_player.Clementine.svg
  icons/apps/48/org.codeblocks.codeblocks.svg
  icons/apps/48/org.darktable.Darktable.svg
  icons/apps/48/org.filezillaproject.Filezilla.svg
  icons/apps/48/org.gimp.GIMP.svg
  icons/apps/48/org.gnu.emacs.svg