D18702: Remove monochrome font preferences icon

2019-02-08 Thread Björn Feber 
GB_2 retitled this revision from "Remove monochrome font preferences icon and 
improve font selection icon" to "Remove monochrome font preferences icon".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon

2019-02-08 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  remove-monochrome-font-preferences-icon-and-improve-font-selection-icon 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon

2019-02-08 Thread Björn Feber 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b5c94b245d1a: Remove monochrome font preferences icon 
(authored by GB_2).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18702?vs=51167&id=51200

REVISION DETAIL
  https://phabricator.kde.org/D18702

AFFECTED FILES
  icons-dark/apps/22/preferences-desktop-font.svg
  icons/apps/22/preferences-desktop-font.svg

To: GB_2, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-03 Thread Björn Feber 
GB_2 created this revision.
GB_2 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Removes the monochrome font preferences icon to prevent showing it instead of 
the colorful icon in the system settings "Fonts" category tooltip. This also 
improves the font selection icons by making the three dots black/white instead 
of orange.
  F6584832: Fixed System Settings Fonts Category Tooltip Icon.png 

  F6584835: Improved Font Selection Icon.png 


TEST PLAN
  Open the system settings and hover over the "Fonts" category. Also search 
"font" in Cuttlefish, it should show the improved font selection icons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  remove-monochrome-font-preferences-icon-and-improve-font-selection-icon 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18702

AFFECTED FILES
  icons-dark/actions/16/gtk-select-font.svg
  icons-dark/actions/22/gtk-select-font.svg
  icons-dark/actions/24/gtk-select-font.svg
  icons-dark/apps/22/preferences-desktop-font.svg
  icons/actions/16/gtk-select-font.svg
  icons/actions/22/gtk-select-font.svg
  icons/actions/24/gtk-select-font.svg
  icons/apps/22/preferences-desktop-font.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-03 Thread Noah Davis 
ndavis added a comment.


  Is this icon used by any other KDE software or 3rd party applications?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-03 Thread Nathaniel Graham 
ngraham added a comment.


  In D18702#404521 , @ndavis wrote:
  
  > Is this icon used by any other KDE software or 3rd party applications?
  
  
  Yes, quite a few: 
https://lxr.kde.org/search?_filestring=&_string=preferences-desktop-font
  
  Those apps won't experience any breakage, but they will suddenly display the 
scaled-down color version.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-03 Thread Björn Feber 
GB_2 added a comment.


  In D18702#404695 , @ngraham wrote:
  
  > In D18702#404521 , @ndavis wrote:
  >
  > > Is this icon used by any other KDE software or 3rd party applications?
  >
  >
  > Yes, quite a few: 
https://lxr.kde.org/search?_filestring=&_string=preferences-desktop-font
  >
  > Those apps won't experience any breakage, but they will suddenly display 
the scaled-down color version.
  
  
  In most places it is used correctly as a SySe category icon and I think it 
would be fine if it would turn into a colorful one.
  It needs to be changes here though (the "All Fonts" list item):
  F6585852: IMG_20190204_073023_364.jpg 
  We could use `gnumeric-font` as an alternative.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-06 Thread Björn Feber 
GB_2 added a dependent revision: D18785: Use different Font Management KCM "All 
Fonts" icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-06 Thread Björn Feber 
GB_2 removed a dependent revision: D18785: Use different Font Management KCM 
"All Fonts" icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-06 Thread Björn Feber 
GB_2 added a dependency: D18785: Use different Font Management KCM "All Fonts" 
icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-07 Thread Nathaniel Graham 
ngraham added a comment.


  Can you improve the font selection icon in a separate patch please?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-07 Thread Björn Feber 
GB_2 added a comment.


  In D18702#407259 , @ngraham wrote:
  
  > Can you improve the font selection icon in a separate patch please?
  
  
  Is it bad that the branch name is wrong then though?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-07 Thread Nathaniel Graham 
ngraham added a comment.


  Nah, that has no effect on anything.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-08 Thread Björn Feber 
GB_2 edited the summary of this revision.
GB_2 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-08 Thread Björn Feber 
GB_2 updated this revision to Diff 51167.
GB_2 added a comment.


  Revert font selection icon change

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18702?vs=50782&id=51167

BRANCH
  remove-monochrome-font-preferences-icon-and-improve-font-selection-icon 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18702

AFFECTED FILES
  icons-dark/apps/22/preferences-desktop-font.svg
  icons/apps/22/preferences-desktop-font.svg

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns