D18972: Format EXIF photo flash data
This revision was automatically updated to reflect the committed changes. Closed by commit R286:e2bd6629783e: Format EXIF photo flash data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18972?vs=51548&id=51555 REVISION DETAIL https://phabricator.kde.org/D18972 AFFECTED FILES autotests/propertyinfotest.cpp src/formatstrings.cpp src/formatstrings_p.h src/propertyinfo.cpp To: astippich, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18972: Format EXIF photo flash data
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OK, looks good then! REPOSITORY R286 KFileMetaData BRANCH format_flash REVISION DETAIL https://phabricator.kde.org/D18972 To: astippich, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18972: Format EXIF photo flash data
astippich added inline comments. INLINE COMMENTS > ngraham wrote in formatstrings.cpp:103 > Does this one mean "present but did not fire" or "there is no flash with this > hardware"? If the latter, I might suggest instead "None". Otherwise this is > fine the way it is. Strictly this means that flash was disabled, not fired and that there is no hardware. These are the strings GwenView and digiKam are using through libexiv2, and I think it makes sense not to deviate from this. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18972 To: astippich, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18972: Format EXIF photo flash data
ngraham added inline comments.
INLINE COMMENTS
> formatstrings.cpp:103
> +const QMap flashTranslation = {
> +{ 0x00, i18nc("Description of photo flash", "No flash")
> },
> +{ 0x01, i18nc("Description of photo flash", "Fired")
> },
Does this one mean "present but did not fire" or "there is no flash with this
hardware"? If the latter, I might suggest instead "None". Otherwise this is
fine the way it is.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D18972
To: astippich, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
D18972: Format EXIF photo flash data
astippich added a comment. The data is taken from exiv2 library: https://github.com/Exiv2/exiv2/blob/master/src/tags_int.cpp#L348 Unfortunately, reusing that data would introduce a lot of #ifdefs in the code, hence I added it to KFileMetaData. This is the only property remaining that needs translation this way which KFileMetaData queries. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18972 To: astippich, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D18972: Format EXIF photo flash data
astippich created this revision. astippich added a reviewer: ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Translate the number of the EXIF photo data to a human readable string. CCBUG: 343273 REPOSITORY R286 KFileMetaData BRANCH format_flash REVISION DETAIL https://phabricator.kde.org/D18972 AFFECTED FILES autotests/propertyinfotest.cpp src/formatstrings.cpp src/formatstrings_p.h src/propertyinfo.cpp To: astippich, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
