D19016: Update Android toolchain files to reality

[Johnny Jazeix]

jjazeix added a comment.


  In D19016#420246 , @apol wrote:
  
  > Applications can still override it, note it's a default.
  >  Also note this: 
https://developer.android.com/distribute/best-practices/develop/target-sdk
  
  
  Ok, good for me :).
  Thanks for the link!

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19016

To: vkrause, apol
Cc: jjazeix, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, 
bruns

D19016: Update Android toolchain files to reality

[Aleix Pol Gonzalez]

apol added a comment.


  Applications can still override it, note it's a default.
  Also note this: 
https://developer.android.com/distribute/best-practices/develop/target-sdk

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19016

To: vkrause, apol
Cc: jjazeix, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, 
bruns

D19016: Update Android toolchain files to reality

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> Android.cmake:150
>  set_deprecated_variable(CMAKE_ANDROID_ARCH_ABI ANDROID_ABI "armeabi-v7a")
> -set_deprecated_variable(CMAKE_ANDROID_API ANDROID_API_LEVEL "14")
> +set_deprecated_variable(CMAKE_ANDROID_API ANDROID_API_LEVEL "21")
>  

Sorry, I'm a bit late, but would it be possible to put 16 as minimum here? Some 
projects (GCompris at least) do not use KF5 and would like to target lower API 
levels.
I can do the diff/commit to change it if necessary

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19016

To: vkrause, apol
Cc: jjazeix, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, 
bruns

D19016: Update Android toolchain files to reality

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:81374904954b: Update Android toolchain files to reality 
(authored by vkrause).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19016?vs=51701=51749

REVISION DETAIL
  https://phabricator.kde.org/D19016

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19016: Update Android toolchain files to reality

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19016

To: vkrause, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19016: Update Android toolchain files to reality

[Volker Krause]

vkrause created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  - NDK r18 does not ship GCC anymore, it's only clang now
  - same for STL, there's only libc++ there
  - API level 14 is not supported either anymore, the minimum supported by the 
current NDK is 16
  - The minimum supported API level by KF5 right now is 21 though, so use that 
as the default

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19016

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns