D19081: Use correct KStandardGuiItem "no" icon

2019-02-16 Thread Björn Feber 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:d5cdd29f9630: Use correct KStandardGuiItem no 
icon (authored by GB_2).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19081?vs=51860=51871

REVISION DETAIL
  https://phabricator.kde.org/D19081

AFFECTED FILES
  src/kstandardguiitem.cpp

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D19081: Use correct KStandardGuiItem "no" icon

2019-02-16 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1.
  
  Of course, Yes/No dialogs themselves should be avoided wherever possible in 
favor of buttons with more descriptive labels (e.g. "Do the Thing / Cancel").
  
  https://hig.kde.org/components/assistance/message.html#appearance

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  use-correct-kstandardguiitem-no-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19081

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D19081: Use correct KStandardGuiItem "no" icon

2019-02-16 Thread Björn Feber 
GB_2 edited the test plan for this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D19081

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D19081: Use correct KStandardGuiItem "no" icon

2019-02-16 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Changes the "no" icon to the correct one that is used in other places too.
  Before:
  F6618736: No Before.jpg 
  
  After:
  F6618737: No After.jpg 

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  use-correct-kstandardguiitem-no-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19081

AFFECTED FILES
  src/kstandardguiitem.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns