D19101: Increase precision of frame rate property

2019-03-02 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:2ab37ed086d8: Increase precision of frame rate property 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19101?vs=52109=53020

REVISION DETAIL
  https://phabricator.kde.org/D19101

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/propertyinfotest.cpp
  src/extractors/ffmpegextractor.cpp
  src/formatstrings.cpp
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

2019-02-19 Thread Stefan Brüns 
bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_framerate

REVISION DETAIL
  https://phabricator.kde.org/D19101

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

2019-02-19 Thread Alexander Stippich 
astippich marked 2 inline comments as done.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19101

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

2019-02-19 Thread Alexander Stippich 
astippich updated this revision to Diff 52109.
astippich added a comment.


  - do not use QString::number

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19101?vs=52103=52109

BRANCH
  ffmpeg_framerate

REVISION DETAIL
  https://phabricator.kde.org/D19101

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/propertyinfotest.cpp
  src/extractors/ffmpegextractor.cpp
  src/formatstrings.cpp
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

2019-02-19 Thread Stefan Brüns 
bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> formatstrings.cpp:152
>  {
> -return QString(value.toString() + i18nc("Symbol of frames per second, 
> with space", " fps"));
> +return QString(QString::number(round(value.toDouble() * 100) / 100) + 
> i18nc("Symbol of frames per second, with space", " fps"));
>  }

No concatenation please, see
https://techbase.kde.org/Development/Tutorials/Localization/i18n_Krazy#Number_Formatting

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19101

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

2019-02-19 Thread Alexander Stippich 
astippich removed a dependency: D19100: Cleanup ffmpeg extractor.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19101

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

2019-02-19 Thread Alexander Stippich 
astippich updated this revision to Diff 52103.
astippich added a comment.


  - rebase on master
  - use exact value in test

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19101?vs=51917=52103

BRANCH
  ffmpeg_framerate

REVISION DETAIL
  https://phabricator.kde.org/D19101

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/propertyinfotest.cpp
  src/extractors/ffmpegextractor.cpp
  src/formatstrings.cpp
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

2019-02-17 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> ffmpegextractortest.cpp:52
>  QCOMPARE(result.properties().value(Height).toInt(), 720);
> +QVERIFY(abs(result.properties().value(FrameRate).toDouble() - 23.976) < 
> 1e-4);
>  }

You can probably use `(24.0/1001)` for the exact value.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19101

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

2019-02-17 Thread Alexander Stippich 
astippich added a dependency: D19100: Cleanup ffmpeg extractor.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19101

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

2019-02-17 Thread Alexander Stippich 
astippich added a dependent revision: D19102: Fix extraction of aspect ratio 
property.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19101

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams