D19318: compile without foreach

2019-03-24 Thread Laurent Montel 
mlaurent added a comment.


  Fixed

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D19318

To: mlaurent, dfaure
Cc: hindenburg, kde-frameworks-devel, michaelh, ngraham, bruns

D19318: compile without foreach

2019-03-23 Thread Kurt Hindenburg 
hindenburg added a comment.


  There's a FOREACH still in the macpoller.cpp file

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D19318

To: mlaurent, dfaure
Cc: hindenburg, kde-frameworks-devel, michaelh, ngraham, bruns

D19318: compile without foreach

2019-03-03 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R274:b072248cc681: compile without foreach (authored by 
mlaurent).

REPOSITORY
  R274 KIdleTime

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19318?vs=52560=53042

REVISION DETAIL
  https://phabricator.kde.org/D19318

AFFECTED FILES
  CMakeLists.txt
  src/kidletime.cpp
  src/widgetbasedpoller.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19318: compile without foreach

2019-03-02 Thread David Faure 
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kidletime.cpp:253
>  
>  if (associations.values().contains(msec)) {
> +const auto listKeys = associations.keys(msec);

Urgh, how horrible and slow. But pre-existing, unrelated to your change.

REPOSITORY
  R274 KIdleTime

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19318

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19318: compile without foreach

2019-02-25 Thread Laurent Montel 
mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

REPOSITORY
  R274 KIdleTime

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19318

AFFECTED FILES
  CMakeLists.txt
  src/kidletime.cpp
  src/widgetbasedpoller.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns