D19326: [Kconfig] Compile without foreach

2019-03-03 Thread Laurent Montel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:38b51667b5ba: [Kconfig] Compile without foreach (authored 
by mlaurent).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19326?vs=52808&id=53040

REVISION DETAIL
  https://phabricator.kde.org/D19326

AFFECTED FILES
  CMakeLists.txt
  autotests/kconfigtest.cpp
  src/core/kauthorized.cpp
  src/core/kconfig.cpp
  src/core/kconfiggroup.h
  src/core/kconfigini.cpp
  src/core/kcoreconfigskeleton.cpp
  src/core/kdesktopfile.cpp
  src/core/ksharedconfig.cpp
  src/gui/kconfigloader.cpp
  src/kconf_update/kconf_update.cpp
  src/kconf_update/kconfigutils.cpp
  src/kconfig_compiler/kconfig_compiler.cpp
  src/kreadconfig/kreadconfig.cpp
  src/kreadconfig/kwriteconfig.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19326: [Kconfig] Compile without foreach

2019-03-02 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19326

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19326: [Kconfig] Compile without foreach

2019-02-28 Thread Laurent Montel 
mlaurent edited the test plan for this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19326

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19326: [Kconfig] Compile without foreach

2019-02-28 Thread Laurent Montel 
mlaurent updated this revision to Diff 52808.
mlaurent added a comment.


  Fixed code as requested by David

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19326?vs=52579&id=52808

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19326

AFFECTED FILES
  CMakeLists.txt
  autotests/kconfigtest.cpp
  src/core/kauthorized.cpp
  src/core/kconfig.cpp
  src/core/kconfiggroup.h
  src/core/kconfigini.cpp
  src/core/kcoreconfigskeleton.cpp
  src/core/kdesktopfile.cpp
  src/core/ksharedconfig.cpp
  src/gui/kconfigloader.cpp
  src/kconf_update/kconf_update.cpp
  src/kconf_update/kconfigutils.cpp
  src/kconfig_compiler/kconfig_compiler.cpp
  src/kreadconfig/kreadconfig.cpp
  src/kreadconfig/kwriteconfig.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19326: [Kconfig] Compile without foreach

2019-02-27 Thread David Faure 
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Did you check that unittests still pass?  (please mention this in the "Test 
Plan:" field of the commit when using arc diff)

INLINE COMMENTS

> ksharedconfig.cpp:93
>  
> -foreach (auto cfg, *static_cast(list)) {
> +const auto listConf = *static_cast(list);
> +for (auto cfg : listConf) {

This looks like a poor man's qAsConst.
Would this work with

  for (auto cfg : qAsConst(*list)) {

?
(not sure)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19326

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19326: [Kconfig] Compile without foreach

2019-02-26 Thread Laurent Montel 
mlaurent retitled this revision from "Compile without foreach" to "[Kconfig] 
Compile without foreach".

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19326

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns