D19442: [Kfilemetada] Make it compile without foreach

[Laurent Montel]

mlaurent abandoned this revision.
mlaurent added a comment.


  I recreated it in "https://phabricator.kde.org/D19655";

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19442

To: mlaurent, dfaure, apol, bruns
Cc: bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, ngraham, abrahams

D19442: [Kfilemetada] Make it compile without foreach

[Stefan Brüns]

bruns reopened this revision.
bruns added a comment.


  Can be rebased/merged now ...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19442

To: mlaurent, dfaure, apol, bruns
Cc: bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, ngraham, abrahams

D19442: [Kfilemetada] Make it compile without foreach

[Laurent Montel]

mlaurent added a comment.


  Arg it was commited by error
  I reverted it

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19442

To: mlaurent, dfaure, apol, bruns
Cc: bruns, astippich, kde-frameworks-devel, #baloo, domson, ashaposhnikov, 
michaelh, spoorun, ngraham, abrahams

D19442: [Kfilemetada] Make it compile without foreach

[Laurent Montel]

This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:fcb1ec08bde9: [Kfilemetada] Make it compile without 
foreach (authored by mlaurent).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19442?vs=52895&id=53096

REVISION DETAIL
  https://phabricator.kde.org/D19442

AFFECTED FILES
  CMakeLists.txt
  src/externalextractor.cpp
  src/externalwriter.cpp
  src/extractorcollection.cpp
  src/extractorplugin.cpp
  src/extractors/office2007extractor.cpp
  src/extractors/taglibextractor.cpp
  src/writercollection.cpp
  tests/dump.cpp

To: mlaurent, dfaure, apol, bruns
Cc: bruns, astippich, kde-frameworks-devel, #baloo, domson, ashaposhnikov, 
michaelh, spoorun, ngraham, abrahams

D19442: [Kfilemetada] Make it compile without foreach

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  This clashes with D19287 , and has to be 
rebased/merged then

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19442

To: mlaurent, dfaure, apol, bruns
Cc: bruns, astippich, kde-frameworks-devel, #baloo, domson, ashaposhnikov, 
michaelh, spoorun, ngraham, abrahams

D19442: [Kfilemetada] Make it compile without foreach

[Alexander Stippich]

astippich added a comment.


  There are currently larger refactorings ongoing (D19287 
, D18826 
), could you please wait for them and 
rebase afterwards?

INLINE COMMENTS

> externalextractor.cpp:151
> +const auto lstKeys = propertiesObject.keys();
> +for(const auto &key : lstKeys) {
>  if (key == QStringLiteral("typeInfo")) {

missing space: for (

> extractorplugin.cpp:140
>  list.reserve(contactStrings.count());
> -foreach(const QString& contactName, contactStrings) {
> +for(const QString& contactName : qAsConst(contactStrings)) {
>  list << contactName.trimmed();

missing space: for (

REPOSITORY
  R286 KFileMetaData

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19442

To: mlaurent, dfaure, apol
Cc: astippich, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, 
spoorun, ngraham, bruns, abrahams

D19442: [Kfilemetada] Make it compile without foreach

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19442

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19442: [Kfilemetada] Make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  Autotest ok

REPOSITORY
  R286 KFileMetaData

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19442

AFFECTED FILES
  CMakeLists.txt
  src/externalextractor.cpp
  src/externalwriter.cpp
  src/extractorcollection.cpp
  src/extractorplugin.cpp
  src/extractors/office2007extractor.cpp
  src/extractors/taglibextractor.cpp
  src/writercollection.cpp
  tests/dump.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams