D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-10-21 Thread Ralf Habacker 
This revision was automatically updated to reflect the committed changes.
Closed by commit R313:2d8cba050729: Extend KHtmlView::print() to use a 
predefined QPrinter instance (authored by habacker).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19504?vs=67894&id=68479#toc

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19504?vs=67894&id=68479

REVISION DETAIL
  https://phabricator.kde.org/D19504

AFFECTED FILES
  src/khtmlview.cpp
  src/khtmlview.h

To: habacker, dfaure, vkrause
Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-10-14 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19504

To: habacker, dfaure, vkrause
Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-10-14 Thread Ahmad Samir 
ahmadsamir added reviewers: dfaure, vkrause.

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19504

To: habacker, dfaure, vkrause
Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-10-14 Thread Ralf Habacker 
habacker updated this revision to Diff 67894.
habacker added a comment.


  - Another attempt after 9 minor releases have elapsed.

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19504?vs=53327&id=67894

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19504

AFFECTED FILES
  src/khtmlview.cpp
  src/khtmlview.h

To: habacker
Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-10-14 Thread Ralf Habacker 
habacker added a comment.


  ping ?

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19504

To: habacker
Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-06 Thread Ralf Habacker 
habacker marked 2 inline comments as done.

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19504

To: habacker
Cc: aacid, tbaumgart, kde-frameworks-devel, michaelh, ngraham, bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-06 Thread Ralf Habacker 
habacker updated this revision to Diff 53327.
habacker marked an inline comment as done.
habacker added a comment.


  - added @since tag
  
  The patch was added to build the stable version of KMyMoney
  for Windows to fix an issue not been able to have common
  printer settings. Since KHTML is the successor of kdelilbs,
  it has been ported to KF5.

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19504?vs=53104&id=53327

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19504

AFFECTED FILES
  src/khtmlview.cpp
  src/khtmlview.h

To: habacker
Cc: aacid, tbaumgart, kde-frameworks-devel, michaelh, ngraham, bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-06 Thread Albert Astals Cid 
aacid added a comment.


  The code is fine, the bigger question here is if we want new features in 
khtml that is part of the "portingAids" part of frameworks.

INLINE COMMENTS

> khtmlview.h:207
> + * @param quick if true, fully automated printing, without print dialog
> + */
> +void print(QPrinter *printer, bool quick = false);

Needs a @since marker.

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19504

To: habacker
Cc: aacid, tbaumgart, kde-frameworks-devel, michaelh, ngraham, bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-06 Thread Ralf Habacker 
habacker marked an inline comment as done.
habacker added inline comments.

INLINE COMMENTS

> tbaumgart wrote in khtmlview.cpp:3134
> Why don't you pass a reference to the QPrinter object here?

Because api  dealing with QPrinter always use a pointer.

void QWebView::print(QPrinter *)
void QPrintPreviewDialog::paintRequested(QPrinter *printer)
QPrintPreviewDialog(QPrinter *printer, QWidget *parent = nullptr, 
Qt::WindowFlags flags = Qt::WindowFlags()
QPrintDialog(QPrinter * printer, QWidget * parent = 0)
QPageSetupDialog(QPrinter *printer, QWidget *parent)
QPrintPreviewWidget(QPrinter *printer, QWidget *parent, Qt::WindowFlags flags)

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19504

To: habacker
Cc: tbaumgart, kde-frameworks-devel, michaelh, ngraham, bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-06 Thread Thomas Baumgart 
tbaumgart added inline comments.

INLINE COMMENTS

> khtmlview.cpp:3134
> +
> +void KHTMLView::print(QPrinter *_printer, bool quick)
> +{

Why don't you pass a reference to the QPrinter object here?

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19504

To: habacker
Cc: tbaumgart, kde-frameworks-devel, michaelh, ngraham, bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

2019-03-04 Thread Ralf Habacker 
habacker created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
habacker requested review of this revision.

REVISION SUMMARY
  This is required to share printer settings inside an application.
  
  BUG:405011

TEST PLAN
  compile on linux

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19504

AFFECTED FILES
  src/khtmlview.cpp
  src/khtmlview.h

To: habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns