D19544: Send blur/background contrast in device pixels
This revision was automatically updated to reflect the committed changes. Closed by commit R278:abcf323ab6f3: Send blur/background contrast in device pixels (authored by davidedmundson). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19544?vs=53210&id=53319 REVISION DETAIL https://phabricator.kde.org/D19544 AFFECTED FILES src/kwindoweffects.h src/platforms/xcb/kwindoweffects.cpp To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D19544: Send blur/background contrast in device pixels
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D19544 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D19544: Send blur/background contrast in device pixels
davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in kwindoweffects.cpp:266 > should we floor or round? Our best option is to match QHighDpi::toNativePixels(QRect) Which seems to floor REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D19544 To: davidedmundson, #kwin Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D19544: Send blur/background contrast in device pixels
zzag added inline comments. INLINE COMMENTS > kwindoweffects.cpp:266 > +auto dpr = qApp->devicePixelRatio(); > +data << r.x() * dpr << r.y() * dpr << r.width() * dpr << > r.height() * dpr; > } should we floor or round? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D19544 To: davidedmundson, #kwin Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D19544: Send blur/background contrast in device pixels
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY A Qt app using Qt scaling will only know the position of windows and all geometry in logical pixels. Kwin needs everything in device pixels. This hasn't been a big issue till now as plasma on X doesn't opt in for Qt scaling. For wayland everything is in the same sane coordinate space. It can occur in some previews in systemsettings and at some point maybe plasma should use Qt scaling on X BUG: 404923 TEST PLAN Task switcher now blurred the whole area. Ran plamsa on X with plasma_use_qt_scaling. Kickoff was less corrupted. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D19544 AFFECTED FILES src/kwindoweffects.h src/platforms/xcb/kwindoweffects.cpp To: davidedmundson, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns
