D19598: DocumentPrivate: Skip auto quotes when these looks already balanced

2019-03-24 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:714948cac1d1: DocumentPrivate: Skip auto quotes when these 
looks already balanced (authored by loh.tar, committed by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19598?vs=53412&id=54665#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19598?vs=53412&id=54665

REVISION DETAIL
  https://phabricator.kde.org/D19598

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/katedocument_test.h
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19598: DocumentPrivate: Skip auto quotes when these looks already balanced

2019-03-21 Thread Christoph Cullmann 
cullmann added a comment.


  For "Is the fix-in number right?" I think yes ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19598

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19598: DocumentPrivate: Skip auto quotes when these looks already balanced

2019-03-21 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Given we have some test that ensures the new behavior is not broken again, I 
have no issues with merging this.
  Did you get your account yet or shall I push?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19598

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19598: DocumentPrivate: Skip auto quotes when these looks already balanced

2019-03-08 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19598

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19598: DocumentPrivate: Skip auto quotes when these looks already balanced

2019-03-08 Thread loh tar 
loh.tar retitled this revision from "DocumentPrivate: Make auto bracket 
slightly smarter" to "DocumentPrivate: Skip auto quotes when these looks 
already balanced".
loh.tar edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19598

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann