D19778: [kitemmodels] make it compile without foreach
This revision was automatically updated to reflect the committed changes. Closed by commit R275:8327e0e0654a: [kitemmodels] make it compile without foreach (authored by mlaurent). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19778?vs=54073&id=54170 REVISION DETAIL https://phabricator.kde.org/D19778 AFFECTED FILES CMakeLists.txt autotests/proxymodeltestsuite/dynamictreemodel.cpp autotests/proxymodeltestsuite/modeleventlogger.cpp autotests/proxymodeltestsuite/modeleventlogger.h autotests/proxymodeltestsuite/modelspy.cpp autotests/proxymodeltestsuite/modelspy.h autotests/proxymodeltestsuite/proxymodeltest.cpp autotests/proxymodeltestsuite/proxymodeltest.h autotests/test_model_helpers.h src/kbreadcrumbselectionmodel.cpp src/kcheckableproxymodel.cpp src/kconcatenaterowsproxymodel.cpp src/kdescendantsproxymodel.cpp src/kextracolumnsproxymodel.cpp src/klinkitemselectionmodel.cpp src/kmodelindexproxymapper.cpp src/krecursivefilterproxymodel.cpp src/kselectionproxymodel.cpp tests/proxymodeltestapp/breadcrumbswidget.cpp tests/proxymodeltestapp/kreparentingproxymodel.cpp tests/proxymodeltestapp/matchcheckingwidget.cpp tests/proxymodeltestapp/modelcommanderwidget.cpp To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19778: [kitemmodels] make it compile without foreach
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19778 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19778: [kitemmodels] make it compile without foreach
mlaurent updated this revision to Diff 54073. mlaurent added a comment. Add missing const, Remove C cast REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19778?vs=53939&id=54073 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19778 AFFECTED FILES CMakeLists.txt autotests/proxymodeltestsuite/dynamictreemodel.cpp autotests/proxymodeltestsuite/modeleventlogger.cpp autotests/proxymodeltestsuite/modeleventlogger.h autotests/proxymodeltestsuite/modelspy.cpp autotests/proxymodeltestsuite/modelspy.h autotests/proxymodeltestsuite/proxymodeltest.cpp autotests/proxymodeltestsuite/proxymodeltest.h autotests/test_model_helpers.h src/kbreadcrumbselectionmodel.cpp src/kcheckableproxymodel.cpp src/kconcatenaterowsproxymodel.cpp src/kdescendantsproxymodel.cpp src/kextracolumnsproxymodel.cpp src/klinkitemselectionmodel.cpp src/kmodelindexproxymapper.cpp src/krecursivefilterproxymodel.cpp src/kselectionproxymodel.cpp tests/proxymodeltestapp/breadcrumbswidget.cpp tests/proxymodeltestapp/kreparentingproxymodel.cpp tests/proxymodeltestapp/matchcheckingwidget.cpp tests/proxymodeltestapp/modelcommanderwidget.cpp To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19778: [kitemmodels] make it compile without foreach
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> modelspy.cpp:323
> d << "ModelSpy(";
> -Q_FOREACH (const QVariantList &list, (QList)(*modelSpy)) {
> +const auto lst = (QList)(*modelSpy);
> +for (const QVariantList &list : lst) {
This is a good opportunity to remove this awful C cast.
const QList lst = *modelSpy;
> kbreadcrumbselectionmodel.cpp:167
> Q_Q(KBreadcrumbSelectionModel);
> QItemSelection deselectedCrumbs = getBreadcrumbSelection(deselected);
> QItemSelection selectedCrumbs = getBreadcrumbSelection(selected);
const
> kbreadcrumbselectionmodel.cpp:168
> QItemSelection deselectedCrumbs = getBreadcrumbSelection(deselected);
> QItemSelection selectedCrumbs = getBreadcrumbSelection(selected);
>
const
REPOSITORY
R275 KItemModels
REVISION DETAIL
https://phabricator.kde.org/D19778
To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19778: [kitemmodels] make it compile without foreach
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY make it compile without foreach TEST PLAN autotest ok REPOSITORY R275 KItemModels BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19778 AFFECTED FILES CMakeLists.txt autotests/proxymodeltestsuite/dynamictreemodel.cpp autotests/proxymodeltestsuite/modeleventlogger.cpp autotests/proxymodeltestsuite/modeleventlogger.h autotests/proxymodeltestsuite/modelspy.cpp autotests/proxymodeltestsuite/modelspy.h autotests/proxymodeltestsuite/proxymodeltest.cpp autotests/proxymodeltestsuite/proxymodeltest.h autotests/test_model_helpers.h src/kbreadcrumbselectionmodel.cpp src/kcheckableproxymodel.cpp src/kconcatenaterowsproxymodel.cpp src/kdescendantsproxymodel.cpp src/kextracolumnsproxymodel.cpp src/klinkitemselectionmodel.cpp src/kmodelindexproxymapper.cpp src/krecursivefilterproxymodel.cpp src/kselectionproxymodel.cpp tests/proxymodeltestapp/breadcrumbswidget.cpp tests/proxymodeltestapp/kreparentingproxymodel.cpp tests/proxymodeltestapp/matchcheckingwidget.cpp tests/proxymodeltestapp/modelcommanderwidget.cpp To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
