D19903: Fix build with msvc

[Albert Astals Cid]

aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.


  yep, having it build with gcc is important :)

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> lazy_val.h:41
>  public:
> -operator decltype(_f()) () const
> +operator auto() const -> decltype(_f())
>  {

Hm recently found out that this code doesn't compile with gcc.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  I don't know who is responsible for this, but noone seems to disagree, so if 
this fixes the build for MSVC and doesn't break other platforms let's go for it?

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Hannah von Reth]

vonreth added a comment.


  So then the workaround is correct, I haven't tried whether the original code 
compiles with CMAKE_CXX_STANDARD=17

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Albert Astals Cid]

aacid added a comment.


  In D19903#435469 , @vonreth wrote:
  
  > Msvc2017.
  >  I think frameworks is still c++11?
  
  
  Not sure, probably yes.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Hannah von Reth]

vonreth added a comment.


  Msvc2017.
  I think frameworks is still c++11?

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Albert Astals Cid]

aacid added a comment.


  Which MSVC is that? it seems the decltype change is workarounding non C++14 
support?

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Hannah von Reth]

vonreth added a comment.


  btw
  
.vim-template:cpp
.vim-template:h
  
  aren't valid file names on windows, and look strange for unix too

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Hannah von Reth]

vonreth added reviewers: mlaurent, davidedmundson, aacid.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Hannah von Reth]

vonreth created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vonreth requested review of this revision.

REVISION SUMMARY
  For the decltype change see https://stackoverflow.com/a/51347067

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19903

AFFECTED FILES
  src/resultset.h
  src/resultset_iterator.cpp
  src/utils/lazy_val.h

To: vonreth
Cc: kde-frameworks-devel, michaelh, ngraham, bruns