D20005: Report human-readable error if Qt5Widgets is required but is not found

2019-03-26 Thread Alexander Potashev 
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:490602677222: Report human-readable error if Qt5Widgets 
is required but is not found (authored by aspotashev).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20005?vs=54695=54832

REVISION DETAIL
  https://phabricator.kde.org/D20005

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: aspotashev, #frameworks, apol
Cc: apol, cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20005: Report human-readable error if Qt5Widgets is required but is not found

2019-03-24 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D20005

To: aspotashev, #frameworks, apol
Cc: apol, cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20005: Report human-readable error if Qt5Widgets is required but is not found

2019-03-24 Thread Albert Astals Cid 
aacid added a comment.


  Makes sense to me

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D20005

To: aspotashev, #frameworks
Cc: cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20005: Report human-readable error if Qt5Widgets is required but is not found

2019-03-24 Thread Alexander Potashev 
aspotashev updated this revision to Diff 54695.
aspotashev retitled this revision from "WIP: Find Qt5Widgets, required for 
Qt5::uic" to "Report human-readable error if Qt5Widgets is required but is not 
found".
aspotashev added a comment.


  Implement probably the most lightweight behaviour.

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20005?vs=54636=54695

REVISION DETAIL
  https://phabricator.kde.org/D20005

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: aspotashev, #frameworks
Cc: cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns