D20021: Add support for extracting data from ogg and ts files

2019-03-25 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:2a76b11e1e9f: Add support for extracting data from ogg 
and ts files (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20021?vs=54726=54752

REVISION DETAIL
  https://phabricator.kde.org/D20021

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/samplefiles/test.ogv
  autotests/samplefiles/test.ts
  src/extractors/ffmpegextractor.cpp
  src/extractors/ffmpegextractor.json

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Stefan Brüns 
bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_ogg_ts

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Alexander Stippich 
astippich updated this revision to Diff 54726.
astippich added a comment.


  - Add failing ogg video test case

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20021?vs=54725=54726

BRANCH
  ffmpeg_ogg_ts

REVISION DETAIL
  https://phabricator.kde.org/D20021

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/samplefiles/test.ogv
  autotests/samplefiles/test.ts
  src/extractors/ffmpegextractor.cpp
  src/extractors/ffmpegextractor.json

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Alexander Stippich 
astippich added a comment.


  forgot rebasing...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Alexander Stippich 
astippich updated this revision to Diff 54725.
astippich added a comment.


  - Add failing ogg video test case

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20021?vs=54707=54725

BRANCH
  ffmpeg_ogg_ts

REVISION DETAIL
  https://phabricator.kde.org/D20021

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h
  autotests/samplefiles/test.ogv
  autotests/samplefiles/test.ts
  src/extractors/ffmpegextractor.cpp
  src/extractors/ffmpegextractor.json

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Stefan Brüns 
bruns added a comment.


  In D20021#437531 , @astippich 
wrote:
  
  > What I meant is that no metadata is currently extracted at all. Is it 
possible to mark a complete test row as expected failure?
  
  
  `QEXPECT_FAIL("Vorbis Video", "Not yet supported", Abort)` before the first 
QCOMPARE should work

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Alexander Stippich 
astippich added a comment.


  What I meant is that no metadata is currently extracted at all. Is it 
possible to mark a complete test row as expected failure?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Alexander Stippich 
astippich updated this revision to Diff 54707.
astippich added a comment.


  - rebase

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20021?vs=54686=54707

BRANCH
  ffmpeg_ogg_ts

REVISION DETAIL
  https://phabricator.kde.org/D20021

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/samplefiles/test.ogv
  autotests/samplefiles/test.ts
  src/extractors/ffmpegextractor.cpp
  src/extractors/ffmpegextractor.json

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Stefan Brüns 
bruns added a comment.


  In D20021#437489 , @astippich 
wrote:
  
  > For reasons unknown, the metadata is not correctly extracted and "title" is 
not found for ogg videos, that's why it is not included there. I would like to 
investigate this later.
  
  
  Can you add it nevertheless, and mark it with a QEXPECT_FAIL, using an extra 
"expectFail" column?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Alexander Stippich 
astippich added a comment.


  For reasons unknown, the metadata is not correctly extracted and "title" is 
not found for ogg videos, that's why it is not included there. I would like to 
investigate this later.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Stefan Brüns 
bruns added a comment.


  According to ffplay, the ogg file has title and the like, so it should be 
listed in the MetaData test.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Alexander Stippich 
astippich added reviewers: ngraham, bruns.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Alexander Stippich 
astippich added a dependency: D20020: Split ffmpeg tests into common properties 
and metadata.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20021

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

2019-03-24 Thread Alexander Stippich 
astippich created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  CCBUG: 399650

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_ogg_ts

REVISION DETAIL
  https://phabricator.kde.org/D20021

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/samplefiles/test.ogv
  autotests/samplefiles/test.ts
  src/extractors/ffmpegextractor.cpp
  src/extractors/ffmpegextractor.json

To: astippich
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams