D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:f18d43b7ffd8: [GridDelegate] Fix gaps in corners of 
thumbnailArea highlight (authored by ndavis).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20140?vs=61167&id=61177

REVISION DETAIL
  https://phabricator.kde.org/D20140

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ndavis, #plasma, #vdg, filipf
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Filip Fila]

filipf accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  grid-delegate-rectangle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg, filipf
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  Anyone want to approve or request changes? It's not perfect, but it's a 
simple improvement. The ideal solution would require us to work around a 
problem with QML where images can't have their corners rounded by a parent 
object's border radius.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis updated this revision to Diff 61167.
ndavis added a comment.


  - Remove radius when thumbnail is present

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20140?vs=55106&id=61167

BRANCH
  grid-delegate-rectangle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20140

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  In D20140#464824 , @ngraham wrote:
  
  > In practice, the thumbnail delegates are much smaller; is anyone gonna 
notice that (famous last words)?
  
  
  If you and anyone else reviewing this patch thinks it's OK, I'll just remove 
the radius for simplicity and consistency, but you seemed like you didn't want 
small bits of whiteness in the corners:
  
  In D20140#440989 , @ngraham wrote:
  
  > It's probably going to be more noticeable for High DPI users. It seems like 
there must be a way to fix this rather than just removing the thumbnail radius.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Nathaniel Graham]

ngraham added a comment.


  In D20140#463834 , @ndavis wrote:
  
  > In D20140#458379 , @filipf wrote:
  >
  > > Which still leaves you with fixing the gaps when there's not thumbnail. 
I'd suggest to do:
  > >
  > > `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2`
  > >
  > > and call it a day :P
  > >
  > > F6800961: image.png 
  >
  >
  > Unfortuantely, that still leaves small white corners on the thumbnails that 
don't take up the entire area.
  >
  > F6819113: Screenshot_20190511_111410.png 

  
  
  In practice, the thumbnail delegates are much smaller; is anyone gonna notice 
that (famous last words)?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  In D20140#458379 , @filipf wrote:
  
  > Which still leaves you with fixing the gaps when there's not thumbnail. I'd 
suggest to do:
  >
  > `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2`
  >
  > and call it a day :P
  >
  > F6800961: image.png 
  
  
  Unfortuantely, that still leaves small white corners on the thumbnails that 
don't take up the entire area. F6819109: Screenshot_20190511_13.png 

  
  I still don't t

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Filip Fila]

filipf added a comment.


  Which still leaves you with fixing the gaps when there's not thumbnail. I'd 
suggest to do:
  
  `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2`
  
  and call it a day :P

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Filip Fila]

filipf added a comment.


  You can fix the rounding bleeding into image previews by doing the following 
at line 116:
  
  `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing`
  
  F6800947: image.png 

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  In D20140#450349 , @GB_2 wrote:
  
  > Ping
  
  
  Sorry, I'm just busy right now and I'm not that familiar with QML, so it 
won't be quick and easy for me.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  Another alternative would be to turn the thumbnail outline into a real 
outline instead of a rounded rectangle behind the thumbnailArea. Then it could 
go on top of the thumbnailArea and the thumbnail highlight could fit perfectly 
inside of it. This would give previews of rectangular images rounded corners 
and is significantly more complicated than the current change, but I feel like 
it should be possible.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  Here is how no radius for the thumbnailArea and thumbnail highlight looks: 
F6739553: Screenshot_20190331_131729.png 

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  In D20140#440989 , @ngraham wrote:
  
  > It's probably going to be more noticeable for High DPI users. It seems like 
there must be a way to fix this rather than just removing the thumbnail radius.
  
  
  I could remove the radius for the thumbnailArea as well. Here's how the 
current change looks at 2x scaling: F6739477: Screenshot_20190331_123652.png 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Nathaniel Graham]

ngraham added a comment.


  It's probably going to be more noticeable for High DPI users. It seems like 
there must be a way to fix this rather than just removing the thumbnail radius.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis updated this revision to Diff 55106.
ndavis added a comment.


  - Remove radius from thumbnailArea highlight

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20140?vs=55105&id=55106

BRANCH
  grid-delegate-rectangle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20140

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  There was a small gap in the corners of the thumbnailArea highlight rectangle 
that was noticable on dark thumbnails.

REPOSITORY
  R296 KDeclarative

BRANCH
  grid-delegate-rectangle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20140

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns