D20169: Add profile support interface for TerminalInterface

2019-06-10 Thread Kurt Hindenburg 
This revision was automatically updated to reflect the committed changes.
Closed by commit R306:11547a552d6b: Add profile support interface for 
TerminalInterface (authored by mschiller, committed by hindenburg).

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20169?vs=58095=59566

REVISION DETAIL
  https://phabricator.kde.org/D20169

AFFECTED FILES
  src/kde_terminal_interface.h

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, LeGast00n, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-06-10 Thread Kurt Hindenburg 
hindenburg accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R306 KParts

BRANCH
  terminal-interface-profiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, LeGast00n, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-06-10 Thread Kurt Hindenburg 
hindenburg edited the summary of this revision.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, LeGast00n, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-06-02 Thread Maximilian Schiller 
mschiller added a comment.


  Oh sry, I wasn't aware of that.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-06-02 Thread Kurt Hindenburg 
hindenburg added a comment.


  In D20169#473105 , @mschiller 
wrote:
  
  > ping
  
  
  I was waiting until the next release of frameworks is out.
  
  5.59  Sat June 1st, 2019  (expected) Sat June 8th, 2019

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-06-02 Thread Maximilian Schiller 
mschiller added a comment.


  ping

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-05-14 Thread Maximilian Schiller 
mschiller updated this revision to Diff 58095.
mschiller added a comment.


  - Remove install of profileinterface

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20169?vs=58094=58095

BRANCH
  terminal-interface-profiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20169

AFFECTED FILES
  src/kde_terminal_interface.h

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-05-14 Thread Maximilian Schiller 
mschiller updated this revision to Diff 58094.
mschiller added a comment.


  Move the interface to TerminalInterfaceV2

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20169?vs=56697=58094

BRANCH
  terminal-interface-profiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20169

AFFECTED FILES
  src/CMakeLists.txt
  src/kde_terminal_interface.h

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-05-14 Thread Kurt Hindenburg 
hindenburg added a comment.


  I would prefer using  TerminalInterfaceV2 in the current file instead of a 
new file. It would make using it much easier to use, document, etc and when kf6 
comes out, easier to re-combine.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-05-13 Thread Dominik Haumann 
dhaumann added a comment.


  @hindenburg: lgtm, could you comment?

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-05-10 Thread Maximilian Schiller 
mschiller added a comment.


  Ping

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-22 Thread Maximilian Schiller 
mschiller updated this revision to Diff 56697.
mschiller added a comment.


  change KDEPARTS to KPARTS

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20169?vs=56696=56697

BRANCH
  terminal-interface-profiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20169

AFFECTED FILES
  src/CMakeLists.txt
  src/terminalprofileinterface.h

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-22 Thread Maximilian Schiller 
mschiller marked 3 inline comments as done.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-22 Thread Maximilian Schiller 
mschiller updated this revision to Diff 56696.
mschiller added a comment.


  Remove getProfilePath and remove get prefixes

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20169?vs=56672=56696

BRANCH
  terminal-interface-profiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20169

AFFECTED FILES
  src/CMakeLists.txt
  src/terminalprofileinterface.h

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-22 Thread Dominik Haumann 
dhaumann added a comment.


  Please fix the API getters: in the KDE/Qt world, getters never start with 
'get': just use availableProdiles() etc.
  
  Similarly, I suggest to rename changeCurrentProfile() to setCurrentProfile().
  
  Could you provide an updated patch?

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-21 Thread Maximilian Schiller 
mschiller added a comment.


  > wrt getProfilePath: what if an application does not store a profile as 
single filename, for example as directory, or even stored e.g. in a DB? maybe 
it would be better to have this as property of a profile
  
  Yeah Konsole Profiles seem to already have a path property in the profile 
implementation. So gonna remove this.
  
  > is a setProfileProperty worth having?
  
  I don't think it would be good to have the user applications mess with the 
users customizations. In case the profile is somehow "incompatible" with the 
client application, exposing some profile management functions (e.g. copy and 
modify) might be useful but I can't think of an actual reason which would 
require that.
  
  > is an API to list the available properties worth having?
  
  Just to check at runtime if getting a property was successful returning an 
empty QVariant should be enough, because you need to look up the available 
properties to check the returned type anyway.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-21 Thread Pino Toscano 
pino added a comment.


  General notes on the API (not a konsole developer though):
  
  - an abstract virtual destructor is needed
  - in kdelibs/kf5 lingo, the "get" as prefix of API getters is generally not 
used
  - `setCurrentProfile` instead of `changeCurrentProfile`? the latter makes me 
think it does changes to the current profile, rather than setting another 
profile as current
  - wrt `changeCurrentProfile`: what will it do if the specified profile name 
does not exist? should the API return true/false to indicate the switch 
actually succeeded?
  - wrt `getProfilePath`: what if an application does not store a profile as 
single filename, for example as directory, or even stored e.g. in a DB? maybe 
it would be better to have this as property of a profile
  - is a `setProfileProperty` worth having?
  - is an API to list the available properties worth having?
  
  Also: this file is still not installed, so it cannot be used. Maybe just add 
the new interface to the existing `kde_terminal_interface.h`?

INLINE COMMENTS

> terminalprofileinterface.h:1
> +// interface.h
> +// Copyright (C)  2002  Dominique Devriese 

either put the right filename, or just remove (IMHO better)

> terminalprofileinterface.h:2
> +// interface.h
> +// Copyright (C)  2002  Dominique Devriese 
> +

this is certainly yours now

> terminalprofileinterface.h:19
> +
> +#ifndef KDELIBS_TERMINALPROFILEINTERFACE_H
> +#define KDELIBS_TERMINALPROFILEINTERFACE_H

I'd go with `KPARTS_etc` (instead of `KDELIBS_etc`)

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-21 Thread Maximilian Schiller 
mschiller updated this revision to Diff 56672.
mschiller edited the summary of this revision.
mschiller added a comment.


  Move the profile support to different class

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20169?vs=55201=56672

BRANCH
  terminal-interface-profiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20169

AFFECTED FILES
  src/terminalprofileinterface.h

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-21 Thread Pino Toscano 
pino added a comment.


  Yes, this change breaks the binary compatibility.  Please add a 
TerminalInterfaceV2 that inherits TerminalInterface instead, or add a separate 
interface for profile handling.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-21 Thread Maximilian Schiller 
mschiller edited the summary of this revision.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-11 Thread Nathaniel Graham 
ngraham added reviewers: cfeck, hein.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-10 Thread Kurt Hindenburg 
hindenburg added a comment.


  Can someone from the frameworks group clarify if this can be committed for 
the next release 5.58 next month?  I know years ago, we had a 
TerminalInterfaceV2 because the interface was changed.
  
  https://community.kde.org/Schedules/Frameworks

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks
Cc: michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-03 Thread Kurt Hindenburg 
hindenburg added a reviewer: Frameworks.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks
Cc: michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

2019-04-01 Thread Maximilian Schiller 
mschiller added a reviewer: hindenburg.
mschiller removed a subscriber: kde-frameworks-devel.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg
Cc: michaelh, ngraham, bruns, kde-frameworks-devel

D20169: Add profile support interface for TerminalInterface

2019-04-01 Thread Maximilian Schiller 
mschiller created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mschiller requested review of this revision.

REVISION SUMMARY
  This enables handling profiles for the active konsolepart and has to
  be implemented by konsole.

REPOSITORY
  R306 KParts

BRANCH
  terminal-interface-profiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20169

AFFECTED FILES
  src/kde_terminal_interface.h

To: mschiller
Cc: kde-frameworks-devel, michaelh, ngraham, bruns