D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Björn Feber 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:47af5254b039: Add notifications and 
notifications-disabled icons (authored by GB_2).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20226?vs=55420=55451

REVISION DETAIL
  https://phabricator.kde.org/D20226

AFFECTED FILES
  icons-dark/actions/16/notifications-disabled.svg
  icons-dark/actions/16/notifications.svg
  icons/actions/16/notifications-disabled.svg
  icons/actions/16/notifications.svg

To: GB_2, #plasma, #vdg, ngraham, ndavis
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Noah Davis 
ndavis accepted this revision.
ndavis added a comment.


  Those curves are perfect 

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-notifications-and-notifications-disabled-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg, ngraham, ndavis
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much nicer! This is a winner IMO.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-notifications-and-notifications-disabled-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg, ngraham
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Björn Feber 
GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Björn Feber 
GB_2 updated this revision to Diff 55420.
GB_2 added a comment.


  Remake icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20226?vs=55347=55420

BRANCH
  add-notifications-and-notifications-disabled-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20226

AFFECTED FILES
  icons-dark/actions/16/notifications-disabled.svg
  icons-dark/actions/16/notifications.svg
  icons/actions/16/notifications-disabled.svg
  icons/actions/16/notifications.svg

To: GB_2, #plasma, #vdg
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Noah Davis 
ndavis added a comment.


  In D20226#442934 , @bruns wrote:
  
  > Diagonal or round shapes are **not** required to be pixel grid aligned. 
Actually, it is not even possible, as there is **always** some antialiasing. It 
even helps to make round shapes a little bit bit larger than the pixel grid, so 
some of the corner/edge pixels are solid color.
  
  
  I'm aware, but that's not the problem. If you look at the left side of the 
bell and the right side, the right side is wider. Maybe it's not that visible 
at 100%/96 DPI, but we should try to have resizable and reusable shapes when 
possible.
  
  F6749114: Screenshot_20190403_112343.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Stefan Brüns 
bruns added a comment.


  In D20226#442902 , @ndavis wrote:
  
  > The proportions aren't quite right.
  >
  > F6749114: Screenshot_20190403_112343.png 

  >
  > This is one way to make a perfectly smooth bell. Subtract the red shapes 
from the black shapes.
  >
  > F6749117: Screenshot_20190403_112550.png 

  >
  > the result is this: F6749121: notifications.svg 

  
  
  Diagonal or round shapes are **not** required to be pixel grid aligned. 
Actually, it is not even possible, as there is **always** some antialiasing. It 
even helps to make round shapes a little bit bit larger than the pixel grid, so 
some of the corner/edge pixels are solid color.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Noah Davis 
ndavis added a comment.


  In D20226#442906 , @GB_2 wrote:
  
  > In D20226#442882 , @ngraham 
wrote:
  >
  > > Also, could we create a 22x22 version too?
  >
  >
  > How can you efficiently do that without having to realign everything to the 
new grid manually?
  
  
  You'll have to create it from scratch again, using the same method you used 
to create the 16px version. If you use the method that I just showed you, it'll 
be much easier than drawing it, but you still need to figure out how to get 
proportions that look right.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, 
bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber 
GB_2 added a comment.


  In D20226#442882 , @ngraham wrote:
  
  > Also, could we create a 22x22 version too?
  
  
  How can you efficiently do that without having to realign everything to the 
new grid manually?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, 
bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Noah Davis 
ndavis added a comment.


  The proportions aren't quite right.
  
  F6749114: Screenshot_20190403_112343.png 

  
  This is one way to make a perfectly smooth bell. Subtract the red shapes from 
the black shapes.
  
  F6749117: Screenshot_20190403_112550.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, 
bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Nathaniel Graham 
ngraham added a comment.


  In D20226#442844 , @GB_2 wrote:
  
  > In D20226#442841 , @ngraham 
wrote:
  >
  > > +1 in general. However the fact that this black version doesn't match the 
outline/dimensions of the colored version 
(`preferences-desktop-notification-bell`) is triggering my OCD. :) Do you think 
you could match the dimensions of that icon?
  >
  >
  > Is that even allowed/possible with this 16x16 resolution?
  >  The padding rules of this resolution don't allow it to be higher.
  
  
  Hmm, well the big issue I see is that the bottom of the colored version 
flares out much more than the bottom of this one does:
  
  F6749058: The two icons.gif 
  
  If that's possible to change within the 16x16 margins, I'll accept it.
  
  Also, could we create a 22x22 version too?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Andres Betts 
abetts added a comment.


  In D20226#442854 , @GB_2 wrote:
  
  > Move bell's pendulum
  
  
  Love it!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber 
GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber 
GB_2 updated this revision to Diff 55347.
GB_2 added a comment.


  Move bell's pendulum

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20226?vs=55339=55347

BRANCH
  add-notifications-and-notifications-disabled-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20226

AFFECTED FILES
  icons-dark/actions/16/notifications-disabled.svg
  icons-dark/actions/16/notifications.svg
  icons/actions/16/notifications-disabled.svg
  icons/actions/16/notifications.svg

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Andres Betts 
abetts added a comment.


  The line that goes across almost completely removes the bell's pendulum to 
the right. Maybe move the pendulum closer to the center so that even when there 
is that red strike line, the user can still make out that it is a notification 
bell

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber 
GB_2 added a comment.


  In D20226#442841 , @ngraham wrote:
  
  > +1 in general. However the fact that this black version doesn't match the 
outline/dimensions of the colored version 
(`preferences-desktop-notification-bell`) is triggering my OCD. :) Do you think 
you could match the dimensions of that icon?
  
  
  Is that even allowed/possible with this 16x16 resolution?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Nathaniel Graham 
ngraham added a comment.


  +1 in general. However the fact that this black version doesn't match the 
outline/dimensions of the colored version 
(`preferences-desktop-notification-bell`) is triggering my OCD. :) Do you think 
you could match the dimensions of that icon?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 406121
  Needed for the upcoming do not disturb mode and overhauled notifcations.
  F6748683: notifications Icon.png 
  F6748684: notifications-disabled Icon.png 


TEST PLAN
  Search for "notifications" in Cuttlefish.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-notifications-and-notifications-disabled-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20226

AFFECTED FILES
  icons-dark/actions/16/notifications-disabled.svg
  icons-dark/actions/16/notifications.svg
  icons/actions/16/notifications-disabled.svg
  icons/actions/16/notifications.svg

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns