D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Vlad Zahorodnii]

zzag added a comment.


  In D20261#443859 , @broulik wrote:
  
  > This is a bug in Quassel, a violation of the FDO spec, it should have ebeen 
`quassel-tray-inactive` or something
  
  
  See https://github.com/quassel/quassel/pull/515

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20261

To: kossebau, #plasma, #vdg
Cc: zzag, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Friedrich W. H. Kossebau]

kossebau abandoned this revision.
kossebau added a comment.


  In D20261#443859 , @broulik wrote:
  
  > I don't see how this could work. IconItem uses the first section as 
filename, for `active-quassel-tray` the word `active` and looks for an 
active.svgz which there isn't. This is a bug in Quassel, a violation of the FDO 
spec, it should have ebeen `quassel-tray-inactive` or something, ordered from 
generic to most specific.
  
  
  So much for blindly done patches relying on testing by actual users :)
  
  Indeed, `IconItem` uses this logic:
  
m_svgIcon->setImagePath(QLatin1String("icons/") + 
sourceString.section(QLatin1Char('-'), 0, 0));
  
  so this change will not work.
  
  But I wonder if this isn't a rather once heuristically-driven assumption of 
Plasma, over anything specified at freedesktop.org?
  I could not find anything related in both
  
https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/
  https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/Icons/
  as well as
  
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#file_formats
  
  Where should/could Quassel developers be pointed to? (Besides, they also have 
some "-inverted" variant based on a config option, which somehow complicates 
things even more, besides the complexity of Plasma theming vs. normal icon 
theming ;) ).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20261

To: kossebau, #plasma, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Kai Uwe Broulik]

broulik added a comment.


  I don't see how this could work. IconItem uses the first section as filename, 
for `active-quassel-tray` the word `active` and looks for an active.svgz which 
there isn't. This is a bug in Quassel, a violation of the FDO spec, it should 
have ebeen `quassel-tray-inactive` or something, ordered from generic to most 
specific.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20261

To: kossebau, #plasma, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Aleix Pol Gonzalez]

apol added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20261

To: kossebau, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Friedrich W. H. Kossebau]

kossebau added a comment.


  To test this quickly, please download the files (View Options>Show Raw File 
(Right)>Download File) and place them in the respective folders 
`/usr/share/plasma/desktoptheme/{air,breeze}/icons/`, then "rm .cache/plasma* 
-r", and restart "plasmashell --replace" e.g. via krunner.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20261

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Since v0.13.0 (17 Nov 2018) quassel uses new names for the systemtray
  status icons. This patch updates the icon name ids.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  updatequasselicons

REVISION DETAIL
  https://phabricator.kde.org/D20261

AFFECTED FILES
  src/desktoptheme/air/icons/quassel.svgz
  src/desktoptheme/breeze/icons/quassel.svgz

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns