D20528: Change properties attributes for consistency

2019-04-16 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:4808263e41bf: Change properties attributes for 
consistency (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20528?vs=56173=56385

REVISION DETAIL
  https://phabricator.kde.org/D20528

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D20528: Change properties attributes for consistency

2019-04-14 Thread Stefan Brüns
bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  10 lines removed, 1 added, 10 times more functionality 

REPOSITORY
  R286 KFileMetaData

BRANCH
  properties_consistency

REVISION DETAIL
  https://phabricator.kde.org/D20528

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D20528: Change properties attributes for consistency

2019-04-14 Thread Alexander Stippich
astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Move all the handling of (string-)lists into
  the member function, and mark the attributes
  consistently.

REPOSITORY
  R286 KFileMetaData

BRANCH
  properties_consistency

REVISION DETAIL
  https://phabricator.kde.org/D20528

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D20528: Change properties attributes for consistency

2019-04-14 Thread Alexander Stippich
astippich added a dependency: D19445: Handle variant list in formatting 
functions.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20528

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams