D20565: Ensure not to fold the end marker

[loh tar]

loh.tar abandoned this revision.
loh.tar added a comment.


  Patch is part of D20606 
  
  > And happy Easter ;=)
  
  Thank you! :-)

REVISION DETAIL
  https://phabricator.kde.org/D20565

To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20565: Ensure not to fold the end marker

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  You can submit that, perhaps with the discussed checks, thanks
  And happy Easter ;=)

REVISION DETAIL
  https://phabricator.kde.org/D20565

To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20565: Ensure not to fold the end marker

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Yes, I am in favor. thanks

REVISION DETAIL
  https://phabricator.kde.org/D20565

To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20565: Ensure not to fold the end marker

[Christoph Cullmann]

cullmann added reviewers: dhaumann, ngraham.
cullmann added a comment.


  I like the idea, its nice for e.g. if then else cascades, you get then out of 
stuff like
  
if (blockwise || range.onSingleLine()) {
lineStart = range.start().column();
remainingChars = range.columnWidth();
} else if (i == range.start().line()) {
lineStart = range.start().column();
} else if (i == range.end().line()) {
remainingChars = range.end().column();
}

if (blockwise || range.onSingleLine()) {
} else if (i == range.start().line()) {
} else if (i == range.end().line()) {
}
  
  which is still nicely readable.
  
  Are others ok with this, too?
  
  For the code: Perhaps one should only adjust at all, if the ranges spans more 
than one line, to avoid accidents.

REVISION DETAIL
  https://phabricator.kde.org/D20565

To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20565: Ensure not to fold the end marker

[loh tar]

loh.tar updated this revision to Diff 56306.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Adjust only on token based folding

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20565?vs=56267=56306

REVISION DETAIL
  https://phabricator.kde.org/D20565

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20565: Ensure not to fold the end marker

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  ...to avoid a deceptive look
  
  With recent fixes was also the closing brace folded which can cause a false 
look of the remaining visible code

TEST PLAN
  Fold differend kind of code, only tested yet with C/C++ where it seems to 
work.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20565

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann