D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  update-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20623

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/drive.svg
  src/desktoptheme/breeze/icons/edit.svg
  src/desktoptheme/breeze/icons/go.svg
  src/desktoptheme/breeze/icons/list.svg
  src/desktoptheme/breeze/icons/media.svg
  src/desktoptheme/breeze/icons/plasmavault.svg
  src/desktoptheme/breeze/icons/plasmavault_error.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis added a comment.


  One concern:
  
  Previously, the `go-up` icon in `go.svg` used a completely different style 
from the other `go-*` icons. Does anyone know why that was? I can't find any 
reason for it to use a different style.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Nathaniel Graham]

ngraham added a comment.


  This looks fine to me, but let's let a #plasma 
 person weigh in too. :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Volume icon are consistent now, Vault icon in tray is prettier (imho), media 
controls look unchanged/fine, folder view nav buttons look fine/better, lgtm

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  update-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  update-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma, broulik, ngraham
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Nathaniel Graham]

ngraham added a comment.


  Submitted D20637  and D20638 
 to keep the Widget Explorer using the 
correct icons after this patch lands.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  update-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma, broulik, ngraham
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bd8264e92869: Update audio, drive, edit, go, list, media, 
plasmavault icons to match breeze… (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20623?vs=56407&id=56464

REVISION DETAIL
  https://phabricator.kde.org/D20623

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/drive.svg
  src/desktoptheme/breeze/icons/edit.svg
  src/desktoptheme/breeze/icons/go.svg
  src/desktoptheme/breeze/icons/list.svg
  src/desktoptheme/breeze/icons/media.svg
  src/desktoptheme/breeze/icons/plasmavault.svg
  src/desktoptheme/breeze/icons/plasmavault_error.svg

To: ndavis, #vdg, #plasma, broulik, ngraham
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns