D20649: [Notify by Portal] Support default action and priority hints

2019-04-18 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:85bdacf738eb: [Notify by Portal] Support default action 
and priority hints (authored by broulik).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20649?vs=56504=56507

REVISION DETAIL
  https://phabricator.kde.org/D20649

AFFECTED FILES
  src/notifybyportal.cpp

To: broulik, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D20649: [Notify by Portal] Support default action and priority hints

2019-04-18 Thread Jan Grulich
jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Works for me. I tested both like the default action and urgency.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20649

To: broulik, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D20649: [Notify by Portal] Support default action and priority hints

2019-04-18 Thread Kai Uwe Broulik
broulik updated this revision to Diff 56504.
broulik added a comment.


  - Support `high`
  - Handle all switch cases

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20649?vs=56494=56504

REVISION DETAIL
  https://phabricator.kde.org/D20649

AFFECTED FILES
  src/notifybyportal.cpp

To: broulik, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D20649: [Notify by Portal] Support default action and priority hints

2019-04-18 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: Frameworks, jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

TEST PLAN
  Compiles, untested as I couldn't figure out the flatpak build system stuff

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20649

AFFECTED FILES
  src/notifybyportal.cpp

To: broulik, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns