D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:2078a10ea1b0: Change input-* device icon styles, add 16px 
icons (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20708?vs=58047=58138

REVISION DETAIL
  https://phabricator.kde.org/D20708

AFFECTED FILES
  icons-dark/actions/16/configure-shortcuts.svg
  icons-dark/actions/16/dialog-input-devices.svg
  icons-dark/actions/22/dialog-input-devices.svg
  icons-dark/devices/16/input-keyboard-virtual.svg
  icons-dark/devices/16/input-keyboard.svg
  icons-dark/devices/16/input-mouse.svg
  icons-dark/devices/16/input-touchpad.svg
  icons-dark/devices/22/input-keyboard-virtual.svg
  icons-dark/devices/22/input-keyboard.svg
  icons-dark/devices/22/input-mouse.svg
  icons/actions/16/configure-shortcuts.svg
  icons/actions/16/dialog-input-devices.svg
  icons/actions/22/dialog-input-devices.svg
  icons/devices/16/input-keyboard-virtual.svg
  icons/devices/16/input-keyboard.svg
  icons/devices/16/input-mouse.svg
  icons/devices/16/input-touchpad.svg
  icons/devices/22/input-keyboard-virtual.svg
  icons/devices/22/input-keyboard.svg
  icons/devices/22/input-mouse.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  input-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis updated this revision to Diff 58047.
ndavis added a comment.


  Add new dialog-input-devices icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20708?vs=56657=58047

BRANCH
  input-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20708

AFFECTED FILES
  icons-dark/actions/16/configure-shortcuts.svg
  icons-dark/actions/16/dialog-input-devices.svg
  icons-dark/actions/22/dialog-input-devices.svg
  icons-dark/devices/16/input-keyboard-virtual.svg
  icons-dark/devices/16/input-keyboard.svg
  icons-dark/devices/16/input-mouse.svg
  icons-dark/devices/16/input-touchpad.svg
  icons-dark/devices/22/input-keyboard-virtual.svg
  icons-dark/devices/22/input-keyboard.svg
  icons-dark/devices/22/input-mouse.svg
  icons/actions/16/configure-shortcuts.svg
  icons/actions/16/dialog-input-devices.svg
  icons/actions/22/dialog-input-devices.svg
  icons/devices/16/input-keyboard-virtual.svg
  icons/devices/16/input-keyboard.svg
  icons/devices/16/input-mouse.svg
  icons/devices/16/input-touchpad.svg
  icons/devices/22/input-keyboard-virtual.svg
  icons/devices/22/input-keyboard.svg
  icons/devices/22/input-mouse.svg

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Nathaniel Graham]

ngraham added a comment.


  I think that looks good!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis added a comment.


  In D20708#454298 , @ngraham wrote:
  
  > Even if only Inkscape currently uses the icon, as a rule we ignore that 
kind of information for code/content in Frameworks, because //in principle// 
any app could use it. It's more important for the icon to be semantically 
correct for any app that  wants to use it than it is for it to match its 
current sole user.
  >
  > For `dialog-input-devices`, I would accept an icon that //includes// a 
drawing tablet, but not one that has //only// a drawing tablet.
  
  
  How is this? 16px F6819133: Screenshot_20190511_114329.png 

  
  I tried making the mouse bigger, but it didn't work out very well since there 
was never quite enough room to make it feel balanced.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Nathaniel Graham]

ngraham added a comment.


  Even if only Inkscape currently uses the icon, as a rule we ignore that kind 
of information for code/content in Frameworks, because //in principle// any app 
could use it. It's more important for the icon to be semantically correct for 
any app that  wants to use it than it is for it to match its current sole user.
  
  For `dialog-input-devices`, I would accept an icon that //includes// a 
drawing tablet, but not one that has //only// a drawing tablet.
  
  We can do the Mouse and Joystick changes in another patch, I just wanted to 
mention them. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis added a comment.


  Actually, `dialog-input-devices` is used by inkscape for configuring pointing 
devices and tablets. AFAIK, only Inkscape uses that icon. If I made it show 
more types of devices, it would be more accurate to use a tablet. Looking at 
the Input Devices dock in Inkscape, it doesn't seem like it would be used much 
for configuring mice, so it might be better if it was just a symlink to the 
`input-tablet` icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis added a comment.


  In D20708#453690 , @ngraham wrote:
  
  > Overall very nice.
  >
  > Instead of symlinking `input-mouse` to `dialog-input-devices`, I think it 
might make more sense to rename `dialog-input-devices` to be `input-mouse` and 
then change the `dialog-input-devices` so that it depicts more than one input 
device, to reinforce its name. Maybe a mouse + keyboard?
  
  
  I don't think I can fit a whole keyboard, but I can probably fit a numpad.
  
  > While you're thinking about input device icons, we also have a few 
outstanding bugs:
  > 
  > - The colorful version of the mouse icon is hard to see on a dark 
background, and also it maybe should have a more generic appearance rather than 
looking like a Razer mouse: https://bugs.kde.org/show_bug.cgi?id=406453
  
  That will be a lot of work and I don't want to do that in this diff since 
it'll slow the rest of the changes down considerably. The most important change 
in this diff is that this is fixed (22px icon where 16px should be): F6786267: 
Screenshot_20190421_215747.png 
  
  > - We need a joystick icon that actually looks like a joystick: 
https://bugs.kde.org/show_bug.cgi?id=406679
  
  I'll do that with the 64px mouse icon fix when I get around to it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Nathaniel Graham]

ngraham added a comment.


  Overall very nice.
  
  Instead of symlinking `input-mouse` to `dialog-input-devices`, I think it 
might make more sense to rename `dialog-input-devices` to be `input-mouse` and 
then change the `dialog-input-devices` so that it depicts more than one input 
device, to reinforce its name. Maybe a mouse + keyboard?
  
  While you're thinking about input device icons, we also have a few 
outstanding bugs:
  
  - The colorful version of the mouse icon is hard to see on a dark background, 
and also it maybe should have a more generic appearance rather than looking 
like a Razer mouse: https://bugs.kde.org/show_bug.cgi?id=406453
  - We need a joystick icon that actually looks like a joystick: 
https://bugs.kde.org/show_bug.cgi?id=406679

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20708: Change input-* device icon styles, add 16px icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  `devices/16` was missing some `input-*` icons.
  `input-keyboard-virtual` looked more like a wireless keyboard than a virtual 
keyboard. 
  Changed `input-keyboard*` style so that it could appear consistent at 16 and 
22px. It also looks a bit more like a real keyboard. 
  Made `configure-shortcuts` icon look good at 16px.

REPOSITORY
  R266 Breeze Icons

BRANCH
  input-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20708

AFFECTED FILES
  icons-dark/actions/16/configure-shortcuts.svg
  icons-dark/devices/16/input-keyboard-virtual.svg
  icons-dark/devices/16/input-keyboard.svg
  icons-dark/devices/16/input-mouse.svg
  icons-dark/devices/16/input-touchpad.svg
  icons-dark/devices/22/input-keyboard-virtual.svg
  icons-dark/devices/22/input-keyboard.svg
  icons-dark/devices/22/input-mouse.svg
  icons/actions/16/configure-shortcuts.svg
  icons/devices/16/input-keyboard-virtual.svg
  icons/devices/16/input-keyboard.svg
  icons/devices/16/input-mouse.svg
  icons/devices/16/input-touchpad.svg
  icons/devices/22/input-keyboard-virtual.svg
  icons/devices/22/input-keyboard.svg
  icons/devices/22/input-mouse.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns