D20995: [Fstab] Add support for non-network filesystems

2019-05-06 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> hallas wrote in fstabhandling.cpp:126
> Yes indeed :D I was just wondering why it was made the way it is? Is there a 
> reason for the limit or was it just because we were only targeting vault type 
> mounts?

fuse filesystems are just to different to say "just add it and see what 
breaks". Other types should be added on a strict whitelist basis.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-06 Thread David Hallas 
hallas added inline comments.

INLINE COMMENTS

> ngraham wrote in fstabhandling.cpp:126
> Now that the refactoring's been done, it should be easy to add support for 
> those or remove the conditional.

Yes indeed :D I was just wondering why it was made the way it is? Is there a 
reason for the limit or was it just because we were only targeting vault type 
mounts?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-06 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> hallas wrote in fstabhandling.cpp:126
> Why do we limit to these two filesystems? I think it would be really useful 
> to show all kinds of fuse based filesystems, e.g. isofs, sshfs and 
> xrdp-chansrv.

Now that the refactoring's been done, it should be easy to add support for 
those or remove the conditional.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-06 Thread David Hallas 
hallas added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:126
> +{
> +if (fstype == "fuse.encfs" ||
> +fstype == "fuse.cryfs") {

Why do we limit to these two filesystems? I think it would be really useful to 
show all kinds of fuse based filesystems, e.g. isofs, sshfs and xrdp-chansrv.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-05 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:116c805ba461: [Fstab] Add support for non-network 
filesystems (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20995?vs=57478=57620

REVISION DETAIL
  https://phabricator.kde.org/D20995

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-05 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Hmm yeah, feels like maybe it should happen in the Panel code to use the 
Product rather than the Description.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-05 Thread Stefan Brüns 
bruns added a comment.


  In D20995#460439 , @ngraham wrote:
  
  > Nice! Can we make the Places panel display the product rather than the 
description? I don't think it's necessary to have the fs type listed there in 
the label. Interested parties can always look that up in the Properties dialog.
  
  
  The open question is if this should happen in solid or in the panel code ... 
I have no strong preference here.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-03 Thread Nathaniel Graham 
ngraham added a comment.


  Nice! Can we make the Places panel display the product rather than the 
description? I don't think it's necessary to have the fs type listed there in 
the label. Interested parties can always look that up in the Properties dialog.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-03 Thread Stefan Brüns 
bruns added a comment.


  F6806745: Screenshot_20190503_180519.png 


REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-03 Thread Stefan Brüns 
bruns edited the summary of this revision.
bruns added a dependency: D20991: [FsTab] Add cache for device file system type.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-03 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Frameworks, ngraham, hallas.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  solid-hardware list details:
  
udi = '/org/kde/fstab/fuse.encfs/home/stefan/Vaults/TestVault'
  parent = '/org/kde/fstab'  (string)
  vendor = 'fuse.encfs'  (string)
  product = '~/Vaults/TestVault'  (string)
  description = '~/Vaults/TestVault (fuse.encfs)'  (string)
  icon = 'folder'  (string)
  StorageAccess.accessible = true  (bool)
  StorageAccess.filePath = '/home/stefan/Vaults/TestVault'  (string)
  StorageAccess.ignored = false  (bool)

udi = '/org/kde/fstab/fuse.cryfs/home/stefan/Vaults/CryTest'
  parent = '/org/kde/fstab'  (string)
  vendor = 'fuse.cryfs'  (string)
  product = '~/Vaults/CryTest'  (string)
  description = '~/Vaults/CryTest (fuse.cryfs)'  (string)
  icon = 'folder'  (string)
  StorageAccess.accessible = true  (bool)
  StorageAccess.filePath = '/home/stefan/Vaults/CryTest'  (string)
  StorageAccess.ignored = false  (bool)

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20995

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns