D21264: Display accurate status message during installation

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R432:2072ac711e15: Display accurate status message during 
installation (authored by ngraham).

REPOSITORY
  R432 File Sharing (Samba) integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21264?vs=58227&id=58228

REVISION DETAIL
  https://phabricator.kde.org/D21264

AFFECTED FILES
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #vdg, #frameworks, ndavis

D21264: Display accurate status message during installation

[Nathaniel Graham]

ngraham updated this revision to Diff 58227.
ngraham added a comment.


  Rebase

REPOSITORY
  R432 File Sharing (Samba) integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21264?vs=58224&id=58227

BRANCH
  update-status-message-during-installation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21264

AFFECTED FILES
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #vdg, #frameworks, ndavis

D21264: Display accurate status message during installation

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R432 File Sharing (Samba) integration

BRANCH
  update-status-message-during-installation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21264

To: ngraham, #vdg, #frameworks, ndavis

D21264: Display accurate status message during installation

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, the status message says "Samba is not installed" during the 
installation.
  Technically this is true, but it really should be describing the current 
status instead.

TEST PLAN
  F6829016: Message-2019-05-17_14.11.04.webm 


REPOSITORY
  R432 File Sharing (Samba) integration

BRANCH
  update-status-message-during-installation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21264

AFFECTED FILES
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #vdg, #frameworks