D21313: Create specific directory for Qt logging categories file

[Ben Cooksley]

bcooksley added a comment.


  The Binary Factory uses the tooling shipped as part of the KDE SDK (which 
always builds everything from scratch, and I don't know if part of that 
includes ECM, hence why the issue doesn't show up there).
  
  The CI system on the other hand uses it's own tooling exclusively on all 
platforms, however because the Android image ships with a limited number of 
libraries it is reliant on the KDE SDK to provide a number of non-KDE 
libraries, and thus has to include the SDK paths when performing builds. 
Unfortunately this means that it is possible on Android for CI builds to be 
contaminated by the SDK - the result of which we're seeing here.
  
  Ideally the SDK would separate the base system (non-KDE) libraries from the 
KDE ones to avoid this issue (and the CI system could therefore rely on it's 
own build results exclusively)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: apol, vkrause, bcooksley, kossebau, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for Qt logging categories file

[Volker Krause]

vkrause added a comment.


  In D21313#480401 , @kossebau wrote:
  
  > @apol @vkrause Perhaps something to check wit the CI or in general with the 
ECM Android toolchain  to make sure the ECM of the host and the target are not 
accidentally mixed or both visible at the same time.
  
  
  Right, I don't understand why it does that though. On binary factory we 
didn't have that problem, and AFAIK they use the same setup?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: apol, vkrause, bcooksley, kossebau, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for Qt logging categories file

[Friedrich W. H. Kossebau]

kossebau added subscribers: vkrause, apol.
kossebau added a comment.


  In D21313#480332 , @bcooksley 
wrote:
  
  > This change appears to be responsible for all Android builds being broken.
  >  See https://build.kde.org/view/Failing/
  >
  > Could someone take a look please?
  
  
  Seems the cause of the build failures is that with the Android builds **not** 
the ECM from the product builds or dep builds is picked up, **but** only the 
ECM as deployed as part of the SDK.
  At least this is what looking at the age of the different builds on CI of the 
ECM product, the dep set and the SDK showed (where SDK was older than this 
change, everything else newer). 
  And triggering a fresh build of the SDK made the builds of the Framework 
builds no longer fail.
  So no issue with this patch, but the Android build setup it seems.
  
  @apol @vkrause Perhaps something to check wit hthe CI or in general to make 
sure the ECM of the host and the target are not accidentally mixed or both 
visible at the same time.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: apol, vkrause, bcooksley, kossebau, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for Qt logging categories file

[Ben Cooksley]

bcooksley added a comment.


  This change appears to be responsible for all Android builds being broken.
  See https://build.kde.org/view/Failing/
  
  Could someone take a look please?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: bcooksley, kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for Qt logging categories file

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:0c95c9f799cd: Create specific directory for Qt logging 
categories file (authored by mlaurent).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58952=58953

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for Qt logging categories file

[Laurent Montel]

mlaurent retitled this revision from "Create specific directory for 
kdebugsettings categories file" to "Create specific directory for Qt logging 
categories file".

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns