D21315: Dolphin-style view modes in the file dialog

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d3098ed7205a: Dolphin-style view modes in the file dialog 
(authored by meven).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21315?vs=58832=59032#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21315?vs=58832=59032

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Nathaniel Graham]

ngraham added a comment.


  5.59 has been tagged, so I think this can land now.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven added a comment.


  In D21315#471780 , @ngraham wrote:
  
  > We're a bit close to Frameworks 5.59 tagging (June 1st). For large patches 
like this, sometimes it's worth waiting for the next release to give it a month 
of testing rather than rushing it in close to the deadline. I say let's wait 
until after tagging to land it, or else if you get a thumbs-up review from 
anyone else before June 1st then we can get it in for 5.59. Does that sound 
sane and sensible?
  
  
  Good suggestion, I keep forgetting about the monthly release and the 
opportunity of beginning to get things merged.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Nathaniel Graham]

ngraham added a comment.


  We're a bit close to Frameworks 5.59 tagging (June 1st). For large patches 
like this, sometimes it's worth waiting for the next release to give it a month 
of testing rather than rushing it in close to the deadline. I say let's wait 
until after tagging to land it, or else if you get a thumbs-up review from 
anyone else before June 1st then we can get it in for 5.59. Does that sound 
sane and sensible?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven added a comment.


  I have made a small code change.
  
  Should I wait for some more review before landing this ?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven updated this revision to Diff 58832.
meven marked an inline comment as done.
meven added a comment.


  Avoid using Toggle in view activation callback names

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21315?vs=58776=58832

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works perfectly and the code looks sensible!

INLINE COMMENTS

> meven wrote in kdiroperator.cpp:1955
> Well there are pretty much reusable already, their actions are available in 
> the actionCollection, although not documented.
> 
> But reusing kdiroperator in dolphin is another matter.
> The views here are simply based on existing kdiroperator views and most of 
> their bugs and features gaps with Dolphin remains.

Yeah, I'm afraid it isn't possible without putting KDirOperator back into 
Dolphin, which was removed on purpose many years ago. I like to see Dolphin 
once again use a re-usable component too, but that's outside the scope of this 
patch.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kdiroperator.cpp:1955
> Can we make them reusable, it should be in framework and then accessed in 
> Dolphin.

Well there are pretty much reusable already, their actions are available in the 
actionCollection, although not documented.

But reusing kdiroperator in dolphin is another matter.
The views here are simply based on existing kdiroperator views and most of 
their bugs and features gaps with Dolphin remains.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven added a dependent revision: D21459: Always save view settings when 
switching from one view mode to another.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven updated this revision to Diff 58776.
meven added a comment.


  Bad comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21315?vs=58775=58776

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham, #vdg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven updated this revision to Diff 58775.
meven added a comment.


  Remove icon zoom settings change this belong to another review

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21315?vs=58774=58775

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham, #vdg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven updated this revision to Diff 58774.
meven added a comment.


  Allow to save different zoom settings for all view kinds

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21315?vs=58642=58774

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham, #vdg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kdiroperator.cpp:1955
>  
> +// View modes that match those of Dolphin
> +KToggleAction *iconsViewAction = new KToggleAction(i18n("Icons View"), 
> this);

Can we make them reusable, it should be in framework and then accessed in 
Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven added a reviewer: VDG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven added a comment.


  ANy

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven updated this revision to Diff 58642.
meven added a comment.


  Fix missing ')'

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21315?vs=58424=58642

BRANCH
  dolphin-view-modes

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven updated this revision to Diff 58424.
meven added a comment.


  Reword Allow Expansion to Allow Expansion in Details View

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21315?vs=58395=58424

BRANCH
  dolphin-view-modes

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Nathaniel Graham]

ngraham added a comment.


  This is fantastic. You fixed all the issues I was having, and the UX is 
practically perfect. The code looks totally sane too. In my testing I found 
only one small issue: when changing the icon size in one view and then 
switching to another view and then back, the first view did not save the new 
size; saving icon sizes only happens when closing the window. With more view 
modes prominently exposed now, it might be nice to save newicon  sizes 
instantly, or when switching to a different view, rather than only saving when 
closing the dialog.

INLINE COMMENTS

> kdiroperator.cpp:2022
>  
> +KToggleAction *allowExpansionAction = new KToggleAction(i18n("Allow 
> Expansion"), this);
> +d->actionCollection->addAction(QStringLiteral("allow expansion"), 
> allowExpansionAction);

Now I wonder if this should say "Allow expansion in Details view" and not 
disable itself when using a different view. Otherwise it might be hard for 
people to figure out what it does or how to activate it.

> kdiroperator.h:963
>  Q_PRIVATE_SLOT(d, void _k_slotDirectoryCreated(const QUrl &))
> +
>  };

Unnecessary whitespace change

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Add Icons, Compact and Details view to the filewidgets.
  
  Added an "Allow Expansion" menu option to toggle between Detailview and 
DetailTreeView
  Moved KDirOperatiorIconView to its own class file.
  Set default icon size for Icons view to 64px (piggy back D12326 
)
  Add a zoom factor specific to compact view (aka simple view with left icons)
  
  Based on P388  and D21283 

  
  Fixes "Make the view modes match the ones in Dolphin (e.g. Icons, Compact, 
and Details, with an option for "Allow expansion" in the settings menu" of 
T8552 

TEST PLAN
  Manual

REPOSITORY
  R241 KIO

BRANCH
  dolphin-view-modes

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns