D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fb8f02de76d5: Make Breeze Light/Dark use more system 
colors (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21378?vs=58575=58880

REVISION DETAIL
  https://phabricator.kde.org/D21378

AFFECTED FILES
  src/desktoptheme/breeze-dark/colors
  src/desktoptheme/breeze-light/colors

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

ndavis added a comment.


  @mart If you're not opposed to this patch, I'll go ahead and land this.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Peridot Lavender]

lavender added a comment.


  In D21378#469640 , @filipf wrote:
  
  > In D21378#469611 , @ndavis wrote:
  >
  > > In D21378#469607 , @filipf 
wrote:
  > >
  > > > So I have a light widget color scheme, but I want to be using a dark 
Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it 
doesn't respect my colors. So this is a good solution, +1 for the idea.
  > > >
  > > > I gave it a quick spin with Breeze Dark however and it's just not 
picking up some color schemes. It remains stuck on the colors of some previous 
scheme that worked. This seems to be random and may be a bug originating 
elsewhere so I'm hitting accept.
  > >
  > >
  > > After changing the system colorscheme, did you try restarting plasmashell 
or switching to a different desktop theme and switching back? I'll admit, it's 
a bit janky, but it should work if you do that. It definitely seems like a bug 
that originates from elsewhere.
  >
  >
  > Restarting plasmashell yes, switching to a different theme nope. But I did 
now and that seems to be working.
  
  
  It's very wonky but what worked for me was: change the desktop theme, not the 
look and feel, then change the color scheme to the one you want and finally 
change the desktop theme to Breeze Dark

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Filip Fila]

filipf added a comment.


  In D21378#469611 , @ndavis wrote:
  
  > In D21378#469607 , @filipf wrote:
  >
  > > So I have a light widget color scheme, but I want to be using a dark 
Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it 
doesn't respect my colors. So this is a good solution, +1 for the idea.
  > >
  > > I gave it a quick spin with Breeze Dark however and it's just not picking 
up some color schemes. It remains stuck on the colors of some previous scheme 
that worked. This seems to be random and may be a bug originating elsewhere so 
I'm hitting accept.
  >
  >
  > After changing the system colorscheme, did you try restarting plasmashell 
or switching to a different desktop theme and switching back? I'll admit, it's 
a bit janky, but it should work if you do that. It definitely seems like a bug 
that originates from elsewhere.
  
  
  Restarting plasmashell yes, switching to a different theme nope. But I did 
now and that seems to be working.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

ndavis added a comment.


  In D21378#469607 , @filipf wrote:
  
  > So I have a light widget color scheme, but I want to be using a dark Plasma 
theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't 
respect my colors. So this is a good solution, +1 for the idea.
  >
  > I gave it a quick spin with Breeze Dark however and it's just not picking 
up some color schemes. It remains stuck on the colors of some previous scheme 
that worked. This seems to be random and may be a bug originating elsewhere so 
I'm hitting accept.
  
  
  After changing the system colorscheme, did you try restarting plasmashell or 
switching to a different desktop theme and switching back?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

ndavis added a comment.


  In D21378#469525 , @lavender wrote:
  
  > In D21378#469517 , @mart wrote:
  >
  > > the idea is kinda nice and with some schemes it will work just perfect...
  > >  however i think it risks a lot of having loss in contrast on certain 
color schems with your patch try for instance breezedark and the honeycomb 
system theme, the current task highlight would probably almost disappear
  >
  >
  > This is bringing it in line with Breeze Light which already has the color 
schemes influencing the taskbar color. I tested with honeycomb and it seemed to 
work fine.
  
  
  Actually, Breeze Light should have had the same problem as Breeze Dark. It's 
Breeze that should have already been adapting to the system colorscheme because 
it didn't have any colors defined.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  So I have a light widget color scheme, but I want to be using a dark Plasma 
theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't 
respect my colors. So this is a good solution, +1 for the idea.
  
  I gave it a quick spin with Breeze Dark however and it's just not picking up 
some color schemes. It remains stuck on the colors of some previous scheme that 
worked. This seems to be random and may be a bug originating elsewhere so I'm 
hitting accept.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Peridot Lavender]

lavender added a comment.


  In D21378#469517 , @mart wrote:
  
  > the idea is kinda nice and with some schemes it will work just perfect...
  >  however i think it risks a lot of having loss in contrast on certain color 
schems with your patch try for instance breezedark and the honeycomb system 
theme, the current task highlight would probably almost disappear
  
  
  This is bringing it in line with Breeze Light which already has the color 
schemes influencing the taskbar color. When I tested I tested with honeycomb 
and it seemed to work fine.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart
Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Marco Martin]

mart added a comment.


  the idea is kinda nice and with some schemes it will work just perfect...
  however i think it risks a lot of having loss in contrast on certain color 
schems with your patch try for instance breezedark and the honeycomb system 
theme, the current task highlight would probably almost disappear

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart
Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a task: T8755: Use colors from the system colorscheme for the 
Task Manager's accent color in Breeze Light/Dark desktop themes.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart
Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Nathaniel Graham]

ngraham added a reviewer: mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart
Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Peridot Lavender]

lavender added a comment.


  Tested and it looks good to me

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma
Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Requested in T8755 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

AFFECTED FILES
  src/desktoptheme/breeze-dark/colors
  src/desktoptheme/breeze-light/colors

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns