D21508: Jam: various improvements and fixes
This revision was automatically updated to reflect the committed changes. Closed by commit R216:6864c25f1d54: Jam: various improvements and fixes (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21508?vs=59150=59164 REVISION DETAIL https://phabricator.kde.org/D21508 AFFECTED FILES autotests/folding/Jamroot.fold autotests/html/Jamroot.html autotests/input/Jamroot autotests/reference/Jamroot.ref data/syntax/jam.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D21508: Jam: various improvements and fixes
dhaumann accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL https://phabricator.kde.org/D21508 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D21508: Jam: various improvements and fixes
jpoelen updated this revision to Diff 59150. jpoelen added a comment. - fix module - remove hard coded color REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21508?vs=58930=59150 BRANCH fix_jam (branched from master) REVISION DETAIL https://phabricator.kde.org/D21508 AFFECTED FILES autotests/folding/Jamroot.fold autotests/html/Jamroot.html autotests/input/Jamroot autotests/reference/Jamroot.ref data/syntax/jam.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D21508: Jam: various improvements and fixes
jpoelen added a comment. I left it because it goes well with dark or light themes, but I removed it. Is the policy the same for bold, underlined and italic as for color? Because a basic applied distinction between Comment and CommentTitle seems to me preferable. I imagine not, but I would like to be sure. In any case I have to do an update because I mixed class and module :/ REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL https://phabricator.kde.org/D21508 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D21508: Jam: various improvements and fixes
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. (the hard coded color was already there, therefore this doesn't block this request) REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL https://phabricator.kde.org/D21508 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D21508: Jam: various improvements and fixes
cullmann added a comment. Looks reasonable + test case, nice. Btw., would it be possible to remove the last remaining hard coded color here, too? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21508 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D21508: Jam: various improvements and fixes
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - fix `x=`: is a rule named `x=`, not a variable - fix `exe onx`: is a rule call, not a variable - fix `ifxxx`, `rulexxx`, etc: not keywords - fix `variable default = xxx ;` - fix keywords and operators in a condition: they must be separated by spaces - fix `on target` - fix `switch` - fix `class` and `module` - fix `for local x` - new styles: Feature and FeatureOperator for ``, `-`, `abc:abc`, `abc/abc`, `abc&` - don't use black color in Rule REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL https://phabricator.kde.org/D21508 AFFECTED FILES autotests/folding/Jamroot.fold autotests/html/Jamroot.html autotests/input/Jamroot autotests/reference/Jamroot.ref data/syntax/jam.xml To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
