D21519: Rename ImageMake and ImageModel properties

2019-06-14 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:131947acb0b2: Rename ImageMake and ImageModel properties 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21519?vs=59676&id=59816

REVISION DETAIL
  https://phabricator.kde.org/D21519

AFFECTED FILES
  src/extractors/exiv2extractor.cpp
  src/properties.h
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-12 Thread Alexander Stippich 
astippich updated this revision to Diff 59676.
astippich added a comment.


  - rename to Manufacturer and Model

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21519?vs=58973&id=59676

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

AFFECTED FILES
  src/extractors/exiv2extractor.cpp
  src/properties.h
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-10 Thread Nathaniel Graham 
ngraham added a comment.


  All right, let's just go with "Manufacturer" and "Model" then. The values for 
these keys will probably make it clear enough.

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-10 Thread Alexander Stippich 
astippich added a comment.


  In D21519#475829 , @bruns wrote:
  
  > In D21519#475821 , @ngraham 
wrote:
  >
  > > "Camera Manufacturer"?
  >
  >
  > Well, no ... also "Scanner, Phone, video digitizer, ..."
  >
  > Digikam just uses "Manufacturer" and "Model", as does Canons DPP
  
  
  That is a strong reason to use just Manufacture and Model then.
  
  > The more I think about it, the more I dislike the enum renaming - reusing a 
strange name from some widely used standard is one thing, but inventing a new 
one I don't consider a good idea.
  
  I'd still like to rename these to "Manufacturer" and "Model". IMHO ImageMake 
and ImageModel is confusing and meaningless.

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-07 Thread Stefan Brüns 
bruns added a comment.


  In D21519#475821 , @ngraham wrote:
  
  > "Camera Manufacturer"?
  
  
  Well, no ... also "Scanner, Phone, video digitizer, ..."
  
  Digikam just uses "Manufacturer" and "Model", as does Canons DPP

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-07 Thread Nathaniel Graham 
ngraham added a comment.


  "Camera Manufacturer"?

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-07 Thread Stefan Brüns 
bruns added a comment.


  In D21519#475781 , @ngraham wrote:
  
  > In D21519#474885 , @astippich 
wrote:
  >
  > > @ngraham what's your take regarding "Manufacturer" vs. "Equipment 
Manufacturer"?
  >
  >
  > "Manufacturer" is shorter, but since the metadata is attached to a photo, 
the longer version might make more sense to cement that it's a property of the 
camera itself, and not the photo!
  
  
  But is it really ambiguous? If it states "Canon", "EOS 70D" or "Nikon", 
"D5000 ", there isn't much room for 
interpretation. Also, "Equipment" is not really fitting very well - what about 
the lense, what about the tripod, the flash(es)? And what/who would a "Photo 
manufacturer" be? We are talking about digital images here.
  
  The more I think about it, the more I dislike the enum renaming - reusing a 
strange name from some widely used standard is one thing, but inventing a new 
one I don't consider a good idea.

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-07 Thread Nathaniel Graham 
ngraham added a comment.


  In D21519#474885 , @astippich 
wrote:
  
  > @ngraham what's your take regarding "Manufacturer" vs. "Equipment 
Manufacturer"?
  
  
  "Manufacturer" is shorter, but since the metadata is attached to a photo, the 
longer version might make more sense to cement that it's a property of the 
camera itself, and not the photo!

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-05 Thread Alexander Stippich 
astippich added a comment.


  @ngraham what's your take regarding "Manufacturer" vs. "Equipment 
Manufacturer"?

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-02 Thread Alexander Stippich 
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in propertyinfo.cpp:185
> Isn't `Manufacturer` sufficient for the label? Same for `Model`.

Well, I wanted to make clear that it is all about the equipment used for 
recording, but if everyone agrees that it is sufficient without  it, I am fine 
with that. @ngraham?

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-02 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> propertyinfo.cpp:185
> +d->name = QStringLiteral("equipmentManufacturer");
> +d->displayName = i18nc("@label EXIF", "Equipment Manufacturer");
>  d->valueType = QVariant::String;

Isn't `Manufacturer` sufficient for the label? Same for `Model`.

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-01 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1, much clearer

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-01 Thread Alexander Stippich 
astippich created this revision.
astippich added reviewers: ngraham, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Provide a more generic and meaningful property
  and display name for the previous ImageMake and
  ImageModel properties.
  
  CCBUG: 343273

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

AFFECTED FILES
  src/extractors/exiv2extractor.cpp
  src/properties.h
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21519: Rename ImageMake and ImageModel properties

2019-06-01 Thread Alexander Stippich 
astippich added a comment.


  If you have a better description for these, please let me know

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams