D21613: Format focal length as milli meter
This revision was automatically updated to reflect the committed changes. Closed by commit R286:8823b8a37d02: Format focal length as milli meter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21613?vs=59560&id=59677 REVISION DETAIL https://phabricator.kde.org/D21613 AFFECTED FILES autotests/propertyinfotest.cpp src/formatstrings.cpp src/formatstrings_p.h src/propertyinfo.cpp To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D21613: Format focal length as milli meter
astippich marked an inline comment as done. REPOSITORY R286 KFileMetaData BRANCH focal_length REVISION DETAIL https://phabricator.kde.org/D21613 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D21613: Format focal length as milli meter
astippich updated this revision to Diff 59560. astippich added a comment. - test decimal value REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21613?vs=59223&id=59560 BRANCH focal_length REVISION DETAIL https://phabricator.kde.org/D21613 AFFECTED FILES autotests/propertyinfotest.cpp src/formatstrings.cpp src/formatstrings_p.h src/propertyinfo.cpp To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D21613: Format focal length as milli meter
bruns added inline comments.
INLINE COMMENTS
> propertyinfotest.cpp:144
> { Property::AspectRatio,true, 1.8,
> QStringLiteral("1.78:1")},
> +{ Property::PhotoFocalLength, true, 2.0,
> QStringLiteral("2 mm")},
> };
For small frame cameras (compact cameras, smartphones, ...) the real focal
length is often in the range of only a few millimeters, please add a test case
which checks e.g. "2.4 mm" is formatted as such.
REPOSITORY
R286 KFileMetaData
BRANCH
focal_length
REVISION DETAIL
https://phabricator.kde.org/D21613
To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh,
astippich, spoorun, ngraham, bruns, abrahams
D21613: Format focal length as milli meter
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH focal_length REVISION DETAIL https://phabricator.kde.org/D21613 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D21613: Format focal length as milli meter
astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH focal_length REVISION DETAIL https://phabricator.kde.org/D21613 AFFECTED FILES autotests/propertyinfotest.cpp src/formatstrings.cpp src/formatstrings_p.h src/propertyinfo.cpp To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
