D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Noah Davis 
ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Noah Davis 
ndavis added a comment.


  I just tried the patch on my own computer and I noticed a few more things 
that need to be changed:
  
  - The canvas size is 128x128 px when it should be 48x48
  - Strokes need to be converted to paths ( [Ctrl] + [Alt] + [c] ). Strokes 
don't always look correct in various SVG renderers, including the Qt renderer.
  - I see you added a shadow inside the darker blue rim, but while you can do 
that, there also needs to be a 1px high shadow on the very bottom for it to 
match the HIG.
- There are some exceptions, but they are not common (or the icon creator 
and reviewers just forgot ¯\_(ツ)_/¯ ).
  - The top left and bottom right corners are not aligned to the grid:
  
  F6888034: Screenshot_20190613_182219.png 

  F6888038: Screenshot_20190613_182302.png 

  
  Suggestions regarding the colors:
  
  - I think the icon would be more recognizable if the board had a darker color 
instead of a lighter color. The board itself could use a gradient, but I assume 
you're still planning to add that.
  - For the indentations, I think they would look more natural if their colors 
were based on the board's colors rather than the pieces' colors.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan 
ognarb updated this revision to Diff 59720.
ognarb added a comment.


  Use more round corner.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21656?vs=59707&id=59720

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan 
ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan 
ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan 
ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan 
ognarb updated this revision to Diff 59707.
ognarb added a comment.


  Change color of some points

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21656?vs=59706&id=59707

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-13 Thread Carl Schwan 
ognarb updated this revision to Diff 59706.
ognarb added a comment.


  Still works in progress (need to add the gradiend) but some improvement

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21656?vs=59372&id=59706

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-08 Thread Nathaniel Graham 
ngraham added a comment.


  Also please add a one-pixel hard bottom shadow.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

2019-06-08 Thread Noah Davis 
ndavis added a comment.


  We don't normally do the gloss wave in Breeze. That's more of a Tango/Oxygen 
thing. How about adding some holes instead to make it look more like the real 
thing? 
https://www.gamesworld.com.au/wp-content/uploads/2015/10/cardinal-four-in-a-row.jpg
  
  Just some ideas: Use light gray or white circles for the holes and black and 
red for the pieces (like in the actual program). Take a look at the `kiriki` 
icon. The way it does indentations can be inspiration for the holes.
  
  I think the icon is lacking gradients, especially the shadows, which are 
always supposed to be linear gradients.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

2019-06-07 Thread Carl Schwan 
ognarb updated this revision to Diff 59372.
ognarb added a comment.


  Crop shadow

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21656?vs=59371&id=59372

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

2019-06-07 Thread Carl Schwan 
ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

2019-06-07 Thread Carl Schwan 
ognarb edited the test plan for this revision.
ognarb added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

2019-06-07 Thread Carl Schwan 
ognarb created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ognarb requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns