D21712: KateModeMenuList: move to QListView

2019-06-15 Thread Nibaldo González 
nibags closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21712

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
bruns, demsking, cullmann, sars, dhaumann

D21712: KateModeMenuList: move to QListView

2019-06-12 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I would say: go for it.
  And thanks for taking care!

REPOSITORY
  R39 KTextEditor

BRANCH
  move-qlistview

REVISION DETAIL
  https://phabricator.kde.org/D21712

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
bruns, demsking, cullmann, sars, dhaumann

D21712: KateModeMenuList: move to QListView

2019-06-12 Thread Nathaniel Graham 
ngraham added a comment.


  +1, thanks!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21712

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
bruns, demsking, cullmann, sars, dhaumann

D21712: KateModeMenuList: move to QListView

2019-06-12 Thread Nibaldo González 
nibags updated this revision to Diff 59631.
nibags added a comment.


  - Update tooltip of search bar

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21712?vs=59577&id=59631

BRANCH
  move-qlistview

REVISION DETAIL
  https://phabricator.kde.org/D21712

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
bruns, demsking, cullmann, sars, dhaumann

D21712: KateModeMenuList: move to QListView

2019-06-11 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> katemodemenulist.cpp:85
>  m_searchBar->setPlaceholderText(i18nc("Placeholder in search bar", 
> "Search..."));
> +m_searchBar->setToolTip(i18nc("ToolTip of the search bar of modes of 
> syntax highlighting", "Search for syntax highlighting mode, by language name 
> or file extension, for example, C++ or .cpp"));
> +m_searchBar->setMaxLength(100);

Recommend a slight change: "Search for syntax highlighting modes by language 
name or file extension (for example, C++ or .cpp)"

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21712

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
bruns, demsking, cullmann, sars, dhaumann

D21712: KateModeMenuList: move to QListView

2019-06-10 Thread Nibaldo González 
nibags updated this revision to Diff 59577.
nibags added a comment.


  - Correct code style
  
  Remove `this->` and `return` at the end of void functions.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21712?vs=59480&id=59577

BRANCH
  move-qlistview

REVISION DETAIL
  https://phabricator.kde.org/D21712

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21712: KateModeMenuList: move to QListView

2019-06-10 Thread Nibaldo González 
nibags edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21712

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21712: KateModeMenuList: move to QListView

2019-06-10 Thread Nibaldo González 
nibags created this revision.
nibags added reviewers: KTextEditor, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  The new Mode menu introduced in D20958  
is updated, removing the use of QListWidget.
  
  This replaces: 
  QListWidget with **QListView + QStandardItemModel** 
  and KListWidgetSearchLine with **QLineEdit**
  
  In addition, some changes are made:
  
  - Decrease delay in displaying search results, after typing. The search 
clearing is done without delays.
  - Add ToolTip in the search bar, with a brief description.
  
  I also made small improvements to the code. From the user's point of view, 
this patch is almost imperceptible.

REPOSITORY
  R39 KTextEditor

BRANCH
  move-qlistview

REVISION DETAIL
  https://phabricator.kde.org/D21712

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann