D21782: Add a warning dialog with details, continue, and cancel button

2019-07-19 Thread Chinmoy Ranjan Pradhan 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:653192440bf8: Add a warning dialog with a collapsible 
details section. (authored by chinmoyr).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21782?vs=60264=62033#toc

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21782?vs=60264=62033

REVISION DETAIL
  https://phabricator.kde.org/D21782

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol
Cc: elvisangelaccio, mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-07-19 Thread Chinmoy Ranjan Pradhan 
chinmoyr edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol
Cc: elvisangelaccio, mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-07-14 Thread Elvis Angelaccio 
elvisangelaccio added inline comments.

INLINE COMMENTS

> kmessagebox.h:329
> + *
> + * @since 5.60
> + */

Needs a bump to 5.61

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol
Cc: elvisangelaccio, mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-07-11 Thread Aleix Pol Gonzalez 
apol accepted this revision.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol
Cc: mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-07-11 Thread Nathaniel Graham 
ngraham added a comment.


  Can we get this in?

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham
Cc: mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-06-21 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham
Cc: mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-06-21 Thread Chinmoy Ranjan Pradhan 
chinmoyr updated this revision to Diff 60264.
chinmoyr added a comment.


  Updated the implementation.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21782?vs=59735=60264

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-06-13 Thread Chinmoy Ranjan Pradhan 
chinmoyr added a comment.


  In D21782#479190 , @GB_2 wrote:
  
  > I think a KCollapsibleGroupBox would fit here: 
http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/
  
  
  Thanks! I'll give it a shot.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-06-13 Thread Nathaniel Graham 
ngraham added a comment.


  In D21782#479190 , @GB_2 wrote:
  
  > I think a KCollapsibleGroupBox would fit here: 
http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/
  
  
  +1, this seems like a perfect use of that widget in fact. Dolphin has an 
example in `viewpropertiesdialog.cpp`.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-06-13 Thread Björn Feber 
GB_2 added a comment.


  I think a KCollapsibleGroupBox would fit here: 
http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-06-13 Thread Chinmoy Ranjan Pradhan 
chinmoyr edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-06-13 Thread Chinmoy Ranjan Pradhan 
chinmoyr created this revision.
chinmoyr added reviewers: VDG, Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  F6887442: warningdialog.png 

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns