D21813: RFC: Consider adding more padding to the desktop theme

[Nathaniel Graham]

ngraham added a comment.


  Or maybe @niccolove would be interested? Could be an alternative to patches 
like D26944 , D26945 
, and D26946 
, and instead we sould just *remove* the 
extra margins and have everything use the theme's default margins.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: niccolove, martinsotirov, abetts, ndavis, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Nathaniel Graham]

ngraham added a subscriber: niccolove.
ngraham added a comment.


  Or maybe @niccolove would be interested?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: niccolove, martinsotirov, abetts, ndavis, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Filip Fila]

filipf added a comment.


  friendly ping
  
  @ndavis would you be willing to give it a go at making a proper patch for 
this (i.e. editing the Breeze svg)?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: martinsotirov, abetts, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Nathaniel Graham]

ngraham added a comment.


  In D21813#481300 , @filipf wrote:
  
  > In D21813#481152 , 
@martinsotirov wrote:
  >
  > > I think Plasma needs a whole lot more padding all over the place, not 
just in the notifications, but I guess there must be some kind of compromise 
with all the people who like more cramped UIs.
  >
  >
  > And in this case it would be easier if we implemented the changes in the 
desktop theme rather than in code because those wanting more cramped UIs could 
just use a different desktop theme (fork an old version e.g.).
  
  
  ...and store it in the new vdg-playground repo (or whatever it's called) and 
make it available on store.kde.org.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: martinsotirov, abetts, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Filip Fila]

filipf added a comment.


  In D21813#481152 , @martinsotirov 
wrote:
  
  > I think Plasma needs a whole lot more padding all over the place, not just 
in the notifications, but I guess there must be some kind of compromise with 
all the people who like more cramped UIs.
  
  
  And in this case it would be easier if we implemented the changes in the 
desktop theme rather than in code because those wanting more cramped UIs could 
just use a different desktop theme (fork an old version e.g.).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: martinsotirov, abetts, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Martin Sotirov]

martinsotirov added a comment.


  I think Plasma needs a whole lot more padding all over the place, not just in 
the notifications, but I guess there must be some kind of compromise with all 
the people who like more cramped UIs.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: martinsotirov, abetts, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Andres Betts]

abetts added a comment.


  +1 on visuals!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: abetts, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Noah Davis]

ndavis added a comment.


  Hmm. I don't think we should increase the padding on the desktop theme. That 
kind of approach seems like it would work best once we know the contents of 
notifications and OSDs are aligned how we want them to be in the code.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Filip Fila]

filipf added a comment.


  In D21813#479950 , @ndavis wrote:
  
  > Besides the notifications, where does this add padding?
  
  
  OSDs as far as I can tell, which are also actually not that roomy:
  
  F6890931: Screenshot_20190615_021457.png 

  
  Before:
  F6890933: Screenshot_20190615_021448.png 

  
  After:
  F6890935: Screenshot_20190615_021522.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Noah Davis]

ndavis added a comment.


  In D21813#479952 , @ngraham wrote:
  
  > I like the rounder corners! :)
  
  
  I don't, but those aren't meant to be discussed in this RFC anyway.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Nathaniel Graham]

ngraham added a comment.


  I like the rounder corners! :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Noah Davis]

ndavis added a comment.


  Besides the notifications, where does this add padding?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Filip Fila]

filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Filip Fila]

filipf edited the test plan for this revision.
filipf added reviewers: Plasma, VDG, ngraham, broulik.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Filip Fila]

filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Instead of tweaking every plasmoid, add a bit more padding to the desktop 
theme.
  
  This would be an alternative solution to D21134 
.
  
  Another postive aspect of this approach is we wouldn't be tweaking paddings 
solely for our desktop theme.
  
  NOTE: The patch is just a copy-paste of Arc-color's background.svg so don't 
judge it based on the different corners or landability. It's meant to encourage 
discussion.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  more-padding-to-desktop-theme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21813

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg

To: filipf
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns