D21919: Change joystick settings icon to game controller

2019-06-20 Thread Noah Davis
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  BUG: 406679
  FIXED-IN: 5.60

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gaming.svg
  icons/preferences/32/preferences-desktop-gaming.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21919: Change joystick settings icon to game controller

2019-06-20 Thread Noah Davis
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21919: Change joystick settings icon to game controller

2019-06-20 Thread Noah Davis
ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21919: Change joystick settings icon to game controller

2019-06-20 Thread David Edmundson
davidedmundson added a comment.


  +1 from me.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21919: Change joystick settings icon to game controller

2019-06-20 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg, ngraham
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21919: Change joystick settings icon to game controller

2019-06-20 Thread Nathaniel Graham
ngraham added a comment.


  Maybe we should also consider renaming the KCM to be "Gaming Controller" 
since I don't know how many people are actually using standalone joysticks 
anymore. I remember that those were all the rage in the 90s, but probably these 
days people are just using their XBox controllers or whatever.

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg, ngraham
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21919: Change joystick settings icon to game controller

2019-06-20 Thread Ömer Fadıl Usta
usta added a comment.


  In D21919#482275 , @ngraham wrote:
  
  > Maybe we should also consider renaming the KCM to be "Gaming Controller" 
since I don't know how many people are actually using standalone joysticks 
anymore. I remember that those were all the rage in the 90s, but probably these 
days people are just using their XBox controllers or whatever.
  
  
  +1 , at least GamePads or Game Controllers

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg, ngraham
Cc: usta, davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns


D21919: Change joystick settings icon to game controller

2019-06-20 Thread Filip Fila
filipf accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg, ngraham, filipf
Cc: usta, davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns


D21919: Change joystick settings icon to game controller

2019-06-20 Thread Nathaniel Graham
ngraham added a comment.


  Looks like that's done in D21922 

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg, ngraham, filipf
Cc: usta, davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns


D21919: Change joystick settings icon to game controller

2019-06-20 Thread Noah Davis
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:7ef3c35c7ed6: Change joystick settings icon to game 
controller (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21919?vs=60102&id=60113

REVISION DETAIL
  https://phabricator.kde.org/D21919

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gaming.svg
  icons/preferences/32/preferences-desktop-gaming.svg

To: ndavis, #vdg, ngraham, filipf
Cc: usta, davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns