D21986: RFC: Change initial size of the config dialog

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I looked into what it would take to make the size adjust to its contents and 
I don't think it's worth the effort here due to the way this dialog is 
constructed. Porting to use a real QtQuick dialog would solve a lot of 
problems, but until we do that, this change is fine.

REPOSITORY
  R495 Purpose Library

BRANCH
  size

REVISION DETAIL
  https://phabricator.kde.org/D21986

To: nicolasfella, #vdg, apol, ngraham
Cc: aacid, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21986: RFC: Change initial size of the config dialog

[Nathaniel Graham]

ngraham added a comment.


  In D21986#484013 , @aacid wrote:
  
  > How hard is to make the size be related to the contents instead of a magic 
number?
  
  
  +1, this would probably involve basing the size on the `StackView`'s child 
items and bubbling that up to the top, rather than setting a hardcoded size at 
the top and making all the child items do `anchors.fill: parent`
  
  If that's ridiculously difficult due to other bugs though, this is a 
reasonable improvement as-is.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D21986

To: nicolasfella, #vdg, apol, ngraham
Cc: aacid, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21986: RFC: Change initial size of the config dialog

[Albert Astals Cid]

aacid added a comment.


  How hard is to make the size be related to the contents instead of a magic 
number?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D21986

To: nicolasfella, #vdg, apol, ngraham
Cc: aacid, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21986: RFC: Change initial size of the config dialog

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D21986

To: nicolasfella, #vdg, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21986: RFC: Change initial size of the config dialog

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: VDG, apol, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The dialog is larger than it needs to be

REPOSITORY
  R495 Purpose Library

BRANCH
  size

REVISION DETAIL
  https://phabricator.kde.org/D21986

AFFECTED FILES
  src/widgets/JobDialog.qml

To: nicolasfella, #vdg, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns