D22216: RFC: Use wayland-protocols

2019-07-03 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.


  It's the technically correct thing to do.
  
  > Generally, I see nothing wrong with waiting until protocol foo becomes part 
of the current wayland-protocols release.
  
  The problem there is that then we're not giving proper feedback until after a 
release, and then it's too late.
  But as you say, we can always copy them.

REPOSITORY
  R127 KWayland

BRANCH
  use-wayland-protocols

REVISION DETAIL
  https://phabricator.kde.org/D22216

To: zzag, #kwin, #frameworks, romangg, davidedmundson
Cc: davidedmundson, apol, romangg, asturmlechner, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D22216: RFC: Use wayland-protocols

2019-07-03 Thread Roman Gilg 
romangg accepted this revision.
romangg added a subscriber: davidedmundson.
romangg added a comment.
This revision is now accepted and ready to land.


  Yea, let's wait until 5.60 branched and then push for 5.61 (after next 
weekend) as long as @davidedmundson does not say anything against it until then.

REPOSITORY
  R127 KWayland

BRANCH
  use-wayland-protocols

REVISION DETAIL
  https://phabricator.kde.org/D22216

To: zzag, #kwin, #frameworks, romangg
Cc: davidedmundson, apol, romangg, asturmlechner, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D22216: RFC: Use wayland-protocols

2019-07-03 Thread Vlad Zagorodniy 
zzag added a comment.


  Also, it's worth to point out that neither weston, nor Mutter, nor wlroots 
copy protocol specs, they just have wayland-protocols as a dependency.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22216

To: zzag, #kwin, #frameworks
Cc: apol, romangg, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22216: RFC: Use wayland-protocols

2019-07-03 Thread Vlad Zagorodniy 
zzag added a comment.


  Generally, I see nothing wrong with waiting until protocol foo becomes part 
of the current wayland-protocols release. If the protocol is really importatnt, 
we can make temporary copy and after several kwayland releases drop it.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22216

To: zzag, #kwin, #frameworks
Cc: apol, romangg, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22216: RFC: Use wayland-protocols

2019-07-03 Thread Vlad Zagorodniy 
zzag added a comment.


  > Why was it done differently until now?
  
  I can't give you an answer, but my guess is for historical reasons. 
Initially, kwayland repo had only proprietary protocols, like 
server_decoration, etc. Protocols from wayland-protocols were copied to follow 
the pattern. Also perhaps because some protocols weren't in the current 
wayland-protocols release yet.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22216

To: zzag, #kwin, #frameworks
Cc: apol, romangg, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22216: RFC: Use wayland-protocols

2019-07-02 Thread Aleix Pol Gonzalez 
apol added a comment.


  Big +1.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22216

To: zzag, #kwin, #frameworks
Cc: apol, romangg, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22216: RFC: Use wayland-protocols

2019-07-02 Thread Roman Gilg 
romangg added a comment.


  Makes sense to me. Why was it done differently until now?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22216

To: zzag, #kwin, #frameworks
Cc: romangg, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D22216: RFC: Use wayland-protocols

2019-07-02 Thread Vlad Zagorodniy 
zzag added a reviewer: Frameworks.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22216

To: zzag, #kwin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22216: RFC: Use wayland-protocols

2019-07-02 Thread Vlad Zagorodniy 
zzag added a comment.


  > find_package(WaylandProtocols 1.15)
  
  because xdg-decoration was introduced in 1.15.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22216

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22216: RFC: Use wayland-protocols

2019-07-02 Thread Vlad Zagorodniy 
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  So far we've been copying protocol specifications from wayland-protocols
  repo to kwayland repo. The main issue with copying is that we have to
  keep xml files in sync manually. A better approach would be to use xml
  specs straight from wayland-protocols package.

TEST PLAN
  Compiles.

REPOSITORY
  R127 KWayland

BRANCH
  use-wayland-protocols

REVISION DETAIL
  https://phabricator.kde.org/D22216

AFFECTED FILES
  CMakeLists.txt
  cmake/Modules/FindWaylandProtocols.cmake
  src/client/CMakeLists.txt
  src/client/protocols/idle-inhibit-unstable-v1.xml
  src/client/protocols/pointer-constraints-unstable-v1.xml
  src/client/protocols/pointer-gestures-unstable-v1.xml
  src/client/protocols/relative-pointer-unstable-v1.xml
  src/client/protocols/xdg-decoration-unstable-v1.xml
  src/client/protocols/xdg-foreign-unstable-v2.xml
  src/client/protocols/xdg-output-unstable-v1.xml
  src/client/protocols/xdg-shell-unstable-v5.xml
  src/client/protocols/xdg-shell-unstable-v6.xml
  src/client/protocols/xdg-shell.xml
  src/server/CMakeLists.txt

To: zzag, #kwin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns